Bug 73105

Summary: In run-bindings-tests, replace subprocess.call() with subprocess.Popen()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dominicc, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 72138    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2011-11-24 20:55:13 PST
Currently, the stdout and stderr of the child processes of run-bindings-tests are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself. This is the problem of subprocess.call(), which does not synchronize the stdout and stderr between a parent process and a child process. We should replace subprocess.call() with subprocess.Popen() and synchronize the stdout and stderr between them. This makes output messages of run-bindings-tests more readable.
Attachments
Patch (6.26 KB, patch)
2011-11-24 21:04 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-11-24 21:04:52 PST
Created attachment 116556 [details] Patch
WebKit Review Bot
Comment 2 2011-11-24 22:44:35 PST
Comment on attachment 116556 [details] Patch Clearing flags on attachment: 116556 Committed r101150: <http://trac.webkit.org/changeset/101150>
WebKit Review Bot
Comment 3 2011-11-24 22:44:40 PST
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 4 2011-11-25 11:13:07 PST
Comment on attachment 116556 [details] Patch As this script grows it should probably move to integrate with the rest of webkitpy (move it's main function onto a new class stored in webkitpy/bindings/main.py, etc.) and use Executive instead of Popen directly for easier mocking/testing.
Kentaro Hara
Comment 5 2011-12-01 21:40:44 PST
(In reply to comment #4) > (From update of attachment 116556 [details]) > As this script grows it should probably move to integrate with the rest of webkitpy (move it's main function onto a new class stored in webkitpy/bindings/main.py, etc.) and use Executive instead of Popen directly for easier mocking/testing. OK, I will move run_bindings_tests to webkitpy/ in bug 73619 and then replace Popen with Executive in another bug.
Eric Seidel (no email)
Comment 6 2011-12-01 22:37:28 PST
Thanks!
Note You need to log in before you can comment on or make changes to this bug.