Bug 71940

Summary: [GTK] Make the ENABLE(FEATURE) macro work in DRT
Product: WebKit Reporter: Alexandre Mazari <scaroo>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66477    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alexandre Mazari
Reported 2011-11-09 11:24:05 PST
[GTK] Make the ENABLE(FEATURE) macro work in DRT
Attachments
Patch (548 bytes, patch)
2011-11-09 11:24 PST, Alexandre Mazari 		no flags
DetailsFormatted DiffDiff
Patch (1.06 KB, patch)
2011-11-10 02:49 PST, Alexandre Mazari 		no flags
DetailsFormatted DiffDiff
Patch (1.17 KB, patch)
2011-11-10 06:12 PST, Alexandre Mazari 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexandre Mazari
Comment 1 2011-11-09 11:24:28 PST
Created attachment 114325 [details] Patch
Philippe Normand
Comment 2 2011-11-09 11:32:18 PST
Comment on attachment 114325 [details] Patch Missing ChangeLog!
Alexandre Mazari
Comment 3 2011-11-10 02:49:42 PST
Created attachment 114463 [details] Patch
Alexandre Mazari
Comment 4 2011-11-10 02:56:34 PST
(In reply to comment #3) > Created an attachment (id=114463) [details] > Patch Updated: - add ChangeLog entry
Philippe Normand
Comment 5 2011-11-10 05:20:18 PST
Comment on attachment 114463 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114463&action=review > Tools/ChangeLog:1 > +2011-11-09 Alexandre Mazari <alexandre.mazari@gmail.com> This is not consistent with your other patches. Any reason to no use your igalia address? > Tools/ChangeLog:9 > + * GNUmakefile.am: > + Even though this is a pretty trivial and small change it would be good to explain it. This is what the ChangeLog entry is about.
Alexandre Mazari
Comment 6 2011-11-10 06:12:36 PST
Created attachment 114482 [details] Patch
Alexandre Mazari
Comment 7 2011-11-10 06:15:02 PST
Hi Philippe, Thanks for your review. (In reply to comment #5) > (From update of attachment 114463 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=114463&action=review > > > Tools/ChangeLog:1 > > +2011-11-09 Alexandre Mazari <alexandre.mazari@gmail.com> > > This is not consistent with your other patches. Any reason to no use your igalia address? Fixed. Don't even know where the changelog generator got this email from :) > > > Tools/ChangeLog:9 > > + * GNUmakefile.am: > > + > > Even though this is a pretty trivial and small change it would be good to explain it. This is what the ChangeLog entry is about. Done.
WebKit Review Bot
Comment 8 2011-11-10 07:24:12 PST
Comment on attachment 114482 [details] Patch Clearing flags on attachment: 114482 Committed r99852: <http://trac.webkit.org/changeset/99852>
WebKit Review Bot
Comment 9 2011-11-10 07:24:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.