Bug 71308

Summary: Switch PopupMenuClient to layout abstraction
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63567    
Attachments:
Description Flags
Patch
none
Patch for landing none

Emil A Eklund
Reported 2011-11-01 11:45:24 PDT
Switch PopupMenuClient and rendering classes implementing it to layout type abstraction.
Attachments
Patch (11.21 KB, patch)
2011-11-01 12:11 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.32 KB, patch)
2011-11-01 15:35 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2011-11-01 12:11:45 PDT
Created attachment 113203 [details] Patch
Darin Adler
Comment 2 2011-11-01 14:01:33 PDT
Comment on attachment 113203 [details] Patch Change log does not offer a rationale for the sites being changed back from LayoutUnit to int.
Emil A Eklund
Comment 3 2011-11-01 14:03:02 PDT
Thanks, I'll make sure to update the ChangeLog to include a justification.
Emil A Eklund
Comment 4 2011-11-01 15:35:13 PDT
Created attachment 113239 [details] Patch for landing
WebKit Review Bot
Comment 5 2011-11-01 17:15:26 PDT
Comment on attachment 113239 [details] Patch for landing Clearing flags on attachment: 113239 Committed r99016: <http://trac.webkit.org/changeset/99016>
WebKit Review Bot
Comment 6 2011-11-01 17:15:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.