Bug 68808

Summary: [Texmap][Qt] Refactor texture-upload to allow direct chunk update
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: Layout and RenderingAssignee: Noam Rosenthal <noam>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, kling, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 56935, 60439    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Noam Rosenthal
Reported 2011-09-26 09:38:59 PDT
The current texture-mapper interface only allows for creating a BGRA32 buffer and painting into it. But in WebKit2, we already have the pixels and want to update them directly into the texture without the extra copy.
Attachments
Patch (10.19 KB, patch)
2011-09-26 09:46 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch (10.23 KB, patch)
2011-09-27 00:28 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch (10.22 KB, patch)
2011-09-27 05:00 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2011-09-26 09:46:24 PDT
Created attachment 108680 [details] Patch
Noam Rosenthal
Comment 2 2011-09-27 00:28:29 PDT
Created attachment 108798 [details] Patch
Andreas Kling
Comment 3 2011-09-27 00:49:10 PDT
Comment on attachment 108798 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108798&action=review > Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:543 > +static void* swizzleBGRAToRGBA(void* data, const IntSize& size) This function should take something more specific than a void*. Also, it has a return type but no return statements. > Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:548 > + uint* p = static_cast<uint*>(data) + y * (width * 4); Is the number of bytes per row always guaranteed to be (width * 4)? > Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:559 > + void* swizzledBits = bits; This appears to be unused. > Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:586 > + break; Wrong indentation.
Noam Rosenthal
Comment 4 2011-09-27 05:00:29 PDT
Created attachment 108824 [details] Patch
Noam Rosenthal
Comment 5 2011-09-27 05:02:47 PDT
> > Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:586 > > + break; > > Wrong indentation. Hmm... I fail to see the error of my ways here. I believe the indentation is correct.
Andreas Kling
Comment 6 2011-09-27 05:06:06 PDT
(In reply to comment #5) > > > Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:586 > > > + break; > > > > Wrong indentation. > Hmm... I fail to see the error of my ways here. > I believe the indentation is correct. It should line up with "glFormat = GL_BGR;" which it doesn't :)
Andreas Kling
Comment 7 2011-09-27 08:40:36 PDT
Comment on attachment 108824 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=108824&action=review r=me > Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:585 > + glFormat = GL_BGR; > +#endif > + break; Indentation police! Wiiiooowiiioooo!
WebKit Review Bot
Comment 8 2011-09-27 09:27:25 PDT
Comment on attachment 108824 [details] Patch Clearing flags on attachment: 108824 Committed r96118: <http://trac.webkit.org/changeset/96118>
WebKit Review Bot
Comment 9 2011-09-27 09:27:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.