Bug 67587

Summary: [Chromium] Android: Need a way to get appropriate font for some specific characters.
Product: WebKit Reporter: Hao Zheng <zhenghao>
Component: New BugsAssignee: Xianzhu Wang <wangxianzhu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cc-bugs, jamesr, peter, wangxianzhu, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Bug Depends on:    
Bug Blocks: 97261, 98770    
Attachments:
Description Flags
Patch none

Hao Zheng
Reported 2011-09-04 23:18:41 PDT
We use fontconfig to getFontFamilyForCharacters and getRenderStyleForStrike in Source/WebKit/chromium/src/PlatformSupport.cpp on Chromium/Linux. However, we do not have fontconfig on Android, so we need a way to implement similar functionality like fontconfig.
Attachments
Patch (371.65 KB, patch)
2012-10-11 21:06 PDT, Xianzhu Wang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xianzhu Wang
Comment 1 2012-10-09 10:14:59 PDT
Depends on Skia bug: http://code.google.com/p/skia/issues/detail?id=913
Xianzhu Wang
Comment 2 2012-10-11 11:21:24 PDT
Peter, for now all tests depending on the internal Skia character font fallback are broken. This is because the change in Skia for http://code.google.com/p/skia/issues/detail?id=913 has just been rolled in. It needs a change in WebKit to use the new character fallback API. The patch will be in this bug. Hopefully I'll finish it today.
Xianzhu Wang
Comment 3 2012-10-11 21:06:33 PDT
Created attachment 168350 [details] Patch
Xianzhu Wang
Comment 4 2012-10-11 21:11:59 PDT
Because of a bug in my previous Skia change, we must wait for the second patch to Skia before landing this patch to WebKit.
Xianzhu Wang
Comment 5 2012-10-16 10:30:28 PDT
The depended Skia change has been in Chromium and will be rolled in WebKit shortly. Adam and James, could you please review the patch? Thanks.
Adam Barth
Comment 6 2012-10-16 12:55:26 PDT
Seems reasonable. I'm not an expert on this code, but your patch seems fine.
Xianzhu Wang
Comment 7 2012-10-16 13:16:53 PDT
Comment on attachment 168350 [details] Patch The depended Skia change has been rolled in WebKit.
WebKit Review Bot
Comment 8 2012-10-16 13:45:32 PDT
Comment on attachment 168350 [details] Patch Clearing flags on attachment: 168350 Committed r131495: <http://trac.webkit.org/changeset/131495>
WebKit Review Bot
Comment 9 2012-10-16 13:45:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.