Bug 65845

Summary: WebSocket: Save the value of useHixie76Protocol flag in WebSocket object
Product: WebKit Reporter: Yuta Kitamura <yutak>
Component: WebCore Misc.Assignee: Yuta Kitamura <yutak>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, ap, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 65247    
Attachments:
Description Flags
Patch none

Yuta Kitamura
Reported 2011-08-08 00:55:02 PDT
[Follow-up of bug 65250] I did not think WebSocket class needed to store the value of useHixie76Protocol flag when I was writing a patch for bug 65250, but it turned out that I was wrong; WebSocket class may need the value of this flag *after* WebSocketChannel is released, because some members may be accessed after the WebSocket connection gets closed.
Attachments
Patch (2.63 KB, patch)
2011-08-08 01:06 PDT, Yuta Kitamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yuta Kitamura
Comment 1 2011-08-08 01:06:33 PDT
Created attachment 103217 [details] Patch
Kent Tamura
Comment 2 2011-08-08 01:13:15 PDT
Comment on attachment 103217 [details] Patch This patch looks just wasting memory. Why don't you add m_useHixie76Protocol when you need it?
Yuta Kitamura
Comment 3 2011-08-08 01:38:38 PDT
(In reply to comment #2) > (From update of attachment 103217 [details]) > This patch looks just wasting memory. > Why don't you add m_useHixie76Protocol when you need it? Sure -- I'll merge this patch into another one which I was planning to post later.
Note You need to log in before you can comment on or make changes to this bug.