Bug 64625

Summary: Add isSpeechInputEnabled flag to WebContextMenuData
Product: WebKit Reporter: gshires
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, satish, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 39485    
Attachments:
Description Flags
Proposed patch
fishd: review+
Proposed patch none

gshires
Reported 2011-07-15 13:55:01 PDT
Created attachment 101040 [details] Proposed patch This flag is to be used by a new menu item "Voice recognition options" which will be added to Chromium. This patch is necessary so that the menu item only appears for input-fields containing the x-webkit-speech attribute. The chromium code that will make use of this patch and that implements the context menu item "Voice recognition options" is: http://codereview.chromium.org/7086005
Attachments
Proposed patch (1.75 KB, patch)
2011-07-15 13:55 PDT, gshires 		fishd: review+
DetailsFormatted DiffDiff
Proposed patch (2.53 KB, patch)
2011-07-19 12:49 PDT, gshires 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Satish Sampath
Comment 1 2011-07-19 00:46:21 PDT
+Darin to approve the addition to WebKit/chromium/public API All patches should have an entry to the appropriate ChangeLog file. For this patch, please add an entry to WebKit/ChangeLog. You can do this with the 'Tools/Scripts/prepare-ChangeLog' script. For more info see http://www.webkit.org/coding/contributing.html#changelogs ContextMenuClientImpl.cpp:264 - should indent by 4 spaces, not 2.
gshires
Comment 2 2011-07-19 12:49:11 PDT
Created attachment 101363 [details] Proposed patch Fixed spacing and added ChangeLog entry.
Tony Gentilcore
Comment 3 2011-07-20 08:29:15 PDT
Comment on attachment 101363 [details] Proposed patch For future reference, when you want a reviewer to add a patch to the commit queue for you just set the cq field to "?". Some committers like to commit manually and it is hard to remember who has committer rights, so typically reviewers will not cq+ unless it is requested.
WebKit Review Bot
Comment 4 2011-07-20 10:02:02 PDT
Comment on attachment 101363 [details] Proposed patch Clearing flags on attachment: 101363 Committed r91377: <http://trac.webkit.org/changeset/91377>
WebKit Review Bot
Comment 5 2011-07-20 10:02:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.