Bug 64405
Summary: | Switch GraphicsContext to operate on floating point coordinates | ||
---|---|---|---|
Product: | WebKit | Reporter: | Levi Weintraub <leviw> |
Component: | Layout and Rendering | Assignee: | Levi Weintraub <leviw> |
Status: | RESOLVED INVALID | ||
Severity: | Normal | CC: | darin, eae, eric, hyatt, mitz, simon.fraser |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | 64413, 65484 | ||
Bug Blocks: | 63567, 64301 |
Levi Weintraub
I'll be attempting to change GraphicsContext functions that take rects, points, and sizes to use floating point versions of these spacial objects.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Simon Fraser (smfr)
On Mac we probably want to use CGFloat, which is a double in 64-bit builds.
Levi Weintraub
Of course, though it then seems that we should really be changing the underlying structure of FloatPoint/FloatRect/FloatSize to an abstraction. The interface needs to be generic.
Simon Fraser (smfr)
Yeah. Time for RenderSize, RenderRect etc? :)
Levi Weintraub
Sounds super ugly, but no time like the present. Any suggestions for the scalar name? RenderScalar? RenderUnit?
The fun never ends :p
Levi Weintraub
Testing with this showed this isn't really necessary. We still want to setup painting on integer bounds to paint cleanly.