Bug 61812

Summary: TestWebKitApi breaks in release mode due to gtest incompatibility with fast malloc
Product: WebKit Reporter: Dmitry Lomov <dslomov>
Component: Tools / TestsAssignee: Dmitry Lomov <dslomov>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dslomov, eric, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57513, 65706    
Attachments:
Description Flags
This disables global fast malloc for TestWebKitAPI.
eric: review-
Only disable fast malloc for offending class in GTest levin: review+, levin: commit-queue-

Dmitry Lomov
Reported 2011-05-31 15:18:02 PDT
TestWebkitAPI crashes on startup in release mode due to malloc/free mismatch: - TestWebKitAPI is compiled with fast malloc for all - gtest uses system malloc.
Attachments
This disables global fast malloc for TestWebKitAPI. (1.39 KB, patch)
2011-05-31 15:30 PDT, Dmitry Lomov 		eric: review-
DetailsFormatted DiffDiff
Only disable fast malloc for offending class in GTest (1.88 KB, patch)
2011-08-03 21:23 PDT, Dmitry Lomov 		levin: review+
levin: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dmitry Lomov
Comment 1 2011-05-31 15:30:42 PDT
Created attachment 95494 [details] This disables global fast malloc for TestWebKitAPI.
David Levin
Comment 2 2011-05-31 16:25:55 PDT
It would be nice to explain this a bit more. Not a lot, just enough so that someone who looks at this (in the future) to understand why this was done would be able to see the problem. Then they could determine if it is still needed, etc.
Eric Seidel (no email)
Comment 3 2011-06-02 08:41:07 PDT
Comment on attachment 95494 [details] This disables global fast malloc for TestWebKitAPI. This needs a comment. Otherwise folks won't understand why we have that line there.
Dmitry Lomov
Comment 4 2011-06-02 11:40:35 PDT
(In reply to comment #3) > (From update of attachment 95494 [details]) > This needs a comment. Otherwise folks won't understand why we have that line there. Yeah I am convinced now that it is not a good fix. Sorry for the noise
Eric Seidel (no email)
Comment 5 2011-06-13 15:16:03 PDT
Sounds like this is WONTFIX then.
Eric Seidel (no email)
Comment 6 2011-06-13 15:16:30 PDT
Oh, nevermind. You're planning to fix this some other way.
Dmitry Lomov
Comment 7 2011-08-03 21:23:46 PDT
Created attachment 102873 [details] Only disable fast malloc for offending class in GTest
David Levin
Comment 8 2011-08-03 21:38:06 PDT
Comment on attachment 102873 [details] Only disable fast malloc for offending class in GTest Given that this is in GTest, I guess it should follow their style for indenting. (It doesn't follow WebKit's style either). Other than it looks fine.
Dmitry Lomov
Comment 9 2011-08-04 10:54:01 PDT
Landed in http://trac.webkit.org/changeset/92387. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.