Bug 60747

Summary: [EFL] Remove unused option of EWeblauncher
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2011-05-12 19:59:16 PDT
IMO, sudo-workaround option is not necessary. It makes EWeblauncher started when --help.
Attachments
Patch (1.24 KB, patch)
2011-05-12 20:03 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2011-05-12 20:03:38 PDT
Created attachment 93393 [details] Patch
Gyuyoung Kim
Comment 2 2011-05-12 20:20:21 PDT
LGTM. Lucas, Do you need this option ?
Lucas De Marchi
Comment 3 2011-05-12 21:00:54 PDT
Comment on attachment 93393 [details] Patch Die die die, unused code! Informal r+ on my side.
WebKit Commit Bot
Comment 4 2011-05-12 21:58:15 PDT
The commit-queue encountered the following flaky tests while processing attachment 93393 [details]: inspector/debugger/debugger-scripts.html bug 59921 (authors: pfeldman@chromium.org and podivilov@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2011-05-12 21:59:27 PDT
Comment on attachment 93393 [details] Patch Clearing flags on attachment: 93393 Committed r86412: <http://trac.webkit.org/changeset/86412>
WebKit Commit Bot
Comment 6 2011-05-12 21:59:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.