Bug 59942

Summary: Add --no-webkit2 to the output of "build-webkit -h"
Product: WebKit Reporter: Nico Weber <thakis>
Component: New BugsAssignee: Nico Weber <thakis>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mihaip, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Nico Weber
Reported 2011-05-02 10:10:00 PDT
Add --no-webkit2 to the output of "build-webkit -h"
Attachments
Patch (1.25 KB, patch)
2011-05-02 10:10 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2011-05-02 10:10:38 PDT
Created attachment 91935 [details] Patch
Nico Weber
Comment 2 2011-05-02 10:11:11 PDT
I always forget if it's --no-webkit2 or --no-webkit-2, and all the other options are in the help output as well.
WebKit Commit Bot
Comment 3 2011-05-02 10:53:26 PDT
The commit-queue encountered the following flaky tests while processing attachment 91935 [details]: http/tests/xmlhttprequest/detaching-frame-2.html bug 52209 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2011-05-02 10:54:43 PDT
Comment on attachment 91935 [details] Patch Clearing flags on attachment: 91935 Committed r85490: <http://trac.webkit.org/changeset/85490>
WebKit Commit Bot
Comment 5 2011-05-02 10:54:48 PDT
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 6 2011-05-02 11:02:51 PDT
Why? WK2 takes like 1 minute to build.
Nico Weber
Comment 7 2011-05-02 11:05:36 PDT
It took several minutes on my machine. Anyway, note that I didn't add the flag, I merely added it to the -h output (which used to contain all options except for this one).
Note You need to log in before you can comment on or make changes to this bug.