Bug 58704

Summary: Decide on node type for ShadowRoot
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: DOMAssignee: Roland Steiner <rolandsteiner>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, dglazkov, dominicc, eric, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 48698, 54179    
Attachments:
Description Flags
Patch
none
patch, cleanup, added WebKit parts dglazkov: review+

Roland Steiner
Reported 2011-04-15 15:39:41 PDT
ShadowRoot currently returns a placeholder DOCUMENT_FRAGMENT_NODE as node type. We need to decide whether to keep that, or whether to introduce a new node type.
Attachments
Patch (23.18 KB, patch)
2011-04-20 17:32 PDT, Roland Steiner 		no flags
DetailsFormatted DiffDiff
patch, cleanup, added WebKit parts (24.74 KB, patch)
2011-04-21 10:26 PDT, Roland Steiner 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-04-19 09:23:19 PDT
Let's just call it SHADOW_ROOT.
Roland Steiner
Comment 2 2011-04-19 13:12:56 PDT
That sounds straightforward. As it so happens, I already have a stashed CL with that exact name... :) Just need to re-land the ShadowRoot patch first.
Dominic Cooney
Comment 3 2011-04-20 11:29:47 PDT
Would we expose this to JavaScript as a constant on Node? Node.SHADOW_ROOT_NODE?
Roland Steiner
Comment 4 2011-04-20 14:43:05 PDT
Good question - I intended not to, to minimize user-visible changes, but perhaps we have to (for inspector, for example)?
Dimitri Glazkov (Google)
Comment 5 2011-04-20 15:26:11 PDT
At this point, let's not worry about JS constants.
Roland Steiner
Comment 6 2011-04-20 17:32:10 PDT
Created attachment 90456 [details] Patch
Dimitri Glazkov (Google)
Comment 7 2011-04-20 21:01:48 PDT
Comment on attachment 90456 [details] Patch nifty.
Roland Steiner
Comment 8 2011-04-21 10:26:07 PDT
Created attachment 90552 [details] patch, cleanup, added WebKit parts New patch, including cleanup after Dominics patch remarks, and added bits for Source/WebKit.
Dimitri Glazkov (Google)
Comment 9 2011-04-21 10:27:44 PDT
Comment on attachment 90552 [details] patch, cleanup, added WebKit parts even niftier.
Roland Steiner
Comment 10 2011-04-21 10:44:27 PDT
Committed r84520: <http://trac.webkit.org/changeset/84520>
WebKit Review Bot
Comment 11 2011-04-21 11:24:41 PDT
http://trac.webkit.org/changeset/84520 might have broken Qt Linux ARMv7 Release and Qt Windows 32-bit Debug
Note You need to log in before you can comment on or make changes to this bug.