Bug 58342

Summary: Teach sub-selector chains about shadow descendants
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, jackalmage, koivisto, menard, sjl
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 58341, 52962    
Attachments:
Description Flags
Patch
none
Patch koivisto: review+, koivisto: commit-queue-

Dimitri Glazkov (Google)
Reported 2011-04-12 10:21:55 PDT
In order to allow styling of the elements, exposed with shadow pseudo-element selector, we need to allow pseudo-classes and possibly other types of selectors (attribute selectors?) to be added at the end of the pseudo-elements.
Attachments
Patch (15.27 KB, patch)
2011-04-16 11:19 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Patch (15.26 KB, patch)
2011-04-19 08:44 PDT, Dimitri Glazkov (Google) 		koivisto: review+
koivisto: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-04-16 11:19:49 PDT
Created attachment 89928 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-04-19 08:44:53 PDT
Created attachment 90207 [details] Patch
Dimitri Glazkov (Google)
Comment 3 2011-04-19 20:10:02 PDT
Antti, can you take a look?
Dimitri Glazkov (Google)
Comment 4 2011-04-20 15:24:20 PDT
Bueller?
Antti Koivisto
Comment 5 2011-04-26 04:11:49 PDT
Comment on attachment 90207 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90207&action=review r=me > Source/WebCore/css/CSSParserValues.h:119 > bool isSimple() const { return !m_tagHistory && m_selector->isSimple(); } > + bool hasShadowDescendant() const; inline like the others?
Dimitri Glazkov (Google)
Comment 6 2011-04-27 11:37:22 PDT
(In reply to comment #5) > (From update of attachment 90207 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=90207&action=review > > r=me > > > Source/WebCore/css/CSSParserValues.h:119 > > bool isSimple() const { return !m_tagHistory && m_selector->isSimple(); } > > + bool hasShadowDescendant() const; > > inline like the others? Sure thing!
Dimitri Glazkov (Google)
Comment 7 2011-04-27 13:32:25 PDT
Committed r85077: <http://trac.webkit.org/changeset/85077>
Note You need to log in before you can comment on or make changes to this bug.