Bug 58086

Summary: Add stub support for generating Gtk build system from gyp
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 55018    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch none

Eric Seidel (no email)
Reported 2011-04-07 14:58:13 PDT
Add stub support for generating Gtk build system from gyp
Attachments
Patch (14.27 KB, patch)
2011-04-07 15:00 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.11 KB, patch)
2011-04-07 15:10 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (9.82 KB, patch)
2011-04-07 15:56 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-04-07 15:00:05 PDT
Created attachment 88708 [details] Patch
Adam Barth
Comment 2 2011-04-07 15:08:31 PDT
Comment on attachment 88708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88708&action=review > Source/JavaScriptCore/gyp/gtk.gyp:11 > + 'variables': { > + 'javascriptcore_include_dirs': [ > + '<(project_dir)', > + '<(project_dir)/icu', > + ], > + }, I'd skip this part. This isn't correct because Gtk doesn't have header maps.
Eric Seidel (no email)
Comment 3 2011-04-07 15:10:33 PDT
Created attachment 88714 [details] Patch for landing
Eric Seidel (no email)
Comment 4 2011-04-07 15:56:14 PDT
Created attachment 88720 [details] Patch
WebKit Review Bot
Comment 5 2011-04-07 15:58:27 PDT
Attachment 88720 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/JavaScriptCore/Change..." exit_code: 1 Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:25: indentation is not a multiple of four [pep8/E111] [5] Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:27: indentation is not a multiple of four [pep8/E111] [5] Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:30: indentation is not a multiple of four [pep8/E111] [5] Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:32: at least two spaces before inline comment [pep8/E261] [5] Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:37: indentation is not a multiple of four [pep8/E111] [5] Source/ThirdParty/gyp/pylib/gyp/generator/filelist.py:40: at least two spaces before inline comment [pep8/E261] [5] Total errors found: 6 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 6 2011-04-07 16:03:53 PDT
Committed r83225: <http://trac.webkit.org/changeset/83225>
Note You need to log in before you can comment on or make changes to this bug.