Bug 58073

Summary: Presence of shadow DOM should suppress rendering of ordinary child nodes
Product: WebKit Reporter: Dominic Cooney <dominicc>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 52962    
Attachments:
Description Flags
Should just see keygen select (shadow), but "Hello world" also appears.
none
Patch
none
Better patch. none

Dominic Cooney
Reported 2011-04-07 13:21:25 PDT
Created attachment 88680 [details] Should just see keygen select (shadow), but "Hello world" also appears. When an element has both ordinary children and shadow children, both appear. The presence of shadow children should suppress the rendering of ordinary children. Repro'd in WK nightly: Version 5.0.4 (6533.20.27, r83161)
Attachments
Should just see keygen select (shadow), but "Hello world" also appears. (33 bytes, text/html)
2011-04-07 13:21 PDT, Dominic Cooney 		no flags
Details
Patch (5.92 KB, patch)
2011-04-13 14:47 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Better patch. (5.92 KB, patch)
2011-04-13 15:11 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-04-13 14:27:51 PDT
(In reply to comment #0) > Created an attachment (id=88680) [details] > Should just see keygen select (shadow), but "Hello world" also appears. > > When an element has both ordinary children and shadow children, both appear. The presence of shadow children should suppress the rendering of ordinary children. > > Repro'd in WK nightly: Version 5.0.4 (6533.20.27, r83161) The reduction is wrong (the parser is smart enough to move the text out to be a child of body), but the problem is still present. Fix coming up...
Dimitri Glazkov (Google)
Comment 2 2011-04-13 14:47:32 PDT
Created attachment 89466 [details] Patch
Ojan Vafai
Comment 3 2011-04-13 15:02:28 PDT
Comment on attachment 89466 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89466&action=review > Source/WebCore/dom/Node.cpp:855 > +inline static ContainerNode* shadowRoot(Node* node) I don't think this inline is really needed. We should reserve inline for cases where we can actually show an improvement, no? But I'm a n00b so feel free to ignore this. :) > Source/WebCore/dom/Node.cpp:1460 > +inline static bool shouldCreateRendererFor(Node* node, ContainerNode* parentForRenderingAndStyle) ditto re: inline
Dimitri Glazkov (Google)
Comment 4 2011-04-13 15:11:49 PDT
Created attachment 89475 [details] Better patch.
WebKit Commit Bot
Comment 5 2011-04-14 18:03:35 PDT
The commit-queue encountered the following flaky tests while processing attachment 89475 [details]: animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2011-04-14 18:06:06 PDT
Comment on attachment 89475 [details] Better patch. Clearing flags on attachment: 89475 Committed r83922: <http://trac.webkit.org/changeset/83922>
WebKit Commit Bot
Comment 7 2011-04-14 18:06:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.