Bug 57947

Summary: Split getBorderPaddingMargin into two functions
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dglazkov, eric, hyatt, rniwa, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 57779    
Attachments:
Description Flags
cleanup none

Ryosuke Niwa
Reported 2011-04-06 07:34:00 PDT
This is a cleanup.
Attachments
cleanup (3.12 KB, patch)
2011-04-06 08:11 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-04-06 08:11:44 PDT
Created attachment 88425 [details] cleanup
Ryosuke Niwa
Comment 2 2011-04-06 08:12:52 PDT
Comment on attachment 88425 [details] cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=88425&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:66 > + // FIXME: Should we call marginStartForChild instead? > return child->marginStart() + child->paddingStart() + child->borderStart(); It's really odd that we don't call marginStartForChild here. This is almost the only place we call marginStart instead. Dave & Simon, this is correct?
Dimitri Glazkov (Google)
Comment 3 2011-04-06 08:51:43 PDT
Comment on attachment 88425 [details] cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=88425&action=review ok. > Source/WebCore/ChangeLog:7 > + Usually I put in something explaining why there aren't tests. Like: Refactoring, covered by existing tests. Or Refactoring, no functional change.
WebKit Commit Bot
Comment 4 2011-04-06 10:06:30 PDT
Comment on attachment 88425 [details] cleanup Clearing flags on attachment: 88425 Committed r83066: <http://trac.webkit.org/changeset/83066>
WebKit Commit Bot
Comment 5 2011-04-06 10:06:35 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2011-04-06 11:05:51 PDT
http://trac.webkit.org/changeset/83066 might have broken GTK Linux 32-bit Release The following tests are not passing: fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html fast/dom/HTMLProgressElement/progress-element.html
Note You need to log in before you can comment on or make changes to this bug.