Bug 57608

Summary: Implement CSSPropertyDirection in CSSStyleApplyProperty
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, macpherson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46592    
Attachments:
Description Flags
Patch none

Luke Macpherson
Reported 2011-03-31 22:33:42 PDT
Implement CSSPropertyDirection in CSSStyleApplyProperty
Attachments
Patch (4.77 KB, patch)
2011-03-31 22:39 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2011-03-31 22:39:05 PDT
Created attachment 87826 [details] Patch
Eric Seidel (no email)
Comment 2 2011-04-03 21:37:47 PDT
Comment on attachment 87826 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87826&action=review Otherwise looks OK. > Source/WebCore/css/CSSStyleApplyProperty.cpp:145 > + ApplyPropertyDirection(TextDirection (RenderStyle::*getter)() const, void (RenderStyle::*setter)(TextDirection), TextDirection (*initial)()) > + : ApplyPropertyDefault<TextDirection>(getter, setter, initial) > + { > + } This isn't needed, or?
Luke Macpherson
Comment 3 2011-04-03 22:38:41 PDT
From IRC: mikelawther: yeah - you can only automatically call a default constructor mikelawther: ie one with no args mikelawther: or one where all the args have default values mikelawther: which is not the case here - so you have to call it explicitly
Dimitri Glazkov (Google)
Comment 4 2011-04-05 07:48:47 PDT
Comment on attachment 87826 [details] Patch ok.
WebKit Commit Bot
Comment 5 2011-04-05 08:33:39 PDT
The commit-queue encountered the following flaky tests while processing attachment 87826 [details]: http/tests/security/xssAuditor/post-from-iframe.html bug 57852 (author: dbates@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2011-04-05 08:36:35 PDT
Comment on attachment 87826 [details] Patch Clearing flags on attachment: 87826 Committed r82942: <http://trac.webkit.org/changeset/82942>
WebKit Commit Bot
Comment 7 2011-04-05 08:36:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.