Bug 56958

Summary: REGRESSION(r77257): Only first page of a document is printed
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: PrintingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, eric, hyatt, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46422    
Attachments:
Description Flags
Reduction
none
Patch that fixes the bug
none
Patch adele: review+

Dimitri Glazkov (Google)
Reported 2011-03-23 13:29:04 PDT
Created attachment 86678 [details] Reduction After http://trac.webkit.org/changeset/77257, the attached reduction no longer prints the entire page, just the first page. It appears that width/height on the P are the culprit. Removing them or making width less than ~600px makes the document print properly again. First seen in: http://code.google.com/p/chromium/issues/detail?id=76694
Attachments
Reduction (3.05 KB, text/html)
2011-03-23 13:29 PDT, Dimitri Glazkov (Google) 		no flags
Details
Patch that fixes the bug (1.23 KB, patch)
2011-03-24 19:02 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (4.24 KB, patch)
2011-03-25 10:29 PDT, Dimitri Glazkov (Google) 		adele: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2011-03-24 19:02:47 PDT
Created attachment 86869 [details] Patch that fixes the bug
Dave Hyatt
Comment 2 2011-03-24 19:03:31 PDT
Overflow needed to be cleared after the current document size was queried. Simple mistake. Needs a test case if one of the Chromium guys wants to finish this off.
Dimitri Glazkov (Google)
Comment 3 2011-03-24 19:08:05 PDT
(In reply to comment #2) > Overflow needed to be cleared after the current document size was queried. Simple mistake. Needs a test case if one of the Chromium guys wants to finish this off. !!!!!111!!! Thanks Dave.
Dimitri Glazkov (Google)
Comment 4 2011-03-25 10:29:04 PDT
Created attachment 86954 [details] Patch
Dimitri Glazkov (Google)
Comment 5 2011-03-25 10:49:20 PDT
Committed r81970: <http://trac.webkit.org/changeset/81970>
Alexey Proskuryakov
Comment 6 2011-03-25 11:03:47 PDT
<rdar://problem/8994076>
WebKit Review Bot
Comment 7 2011-03-25 12:19:36 PDT
http://trac.webkit.org/changeset/81970 might have broken SnowLeopard Intel Release (WebKit2 Tests) The following tests are not passing: printing/page-count-layout-overflow.html
Note You need to log in before you can comment on or make changes to this bug.