Bug 56444

Summary: Add support for Sun Studio 12 compiler on Solaris
Product: WebKit Reporter: Ben Taylor <bentaylor.solx86>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Other   
Attachments:
Description Flags
Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler
ap: review+, ap: commit-queue+
Updated patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler none

Ben Taylor
Reported 2011-03-15 20:59:17 PDT
Adding support for Sun Studio 12 compiler on Solaris 10. This is a derivitive of the first of 16 patches from the bug in https://bugs.webkit.org/show_bug.cgi?id=24932. The other parts of the original patch have already been folded and transformed since the origination of this patch.
Attachments
Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler (1.11 KB, patch)
2011-03-15 21:04 PDT, Ben Taylor 		ap: review+
ap: commit-queue+
DetailsFormatted DiffDiff
Updated patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler (1.16 KB, patch)
2011-03-16 11:37 PDT, Ben Taylor 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ben Taylor
Comment 1 2011-03-15 21:04:49 PDT
Created attachment 85903 [details] Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler This patch is what is remaining uncommited to the webkit source, from the patch 1 of 16 from bug https://bugs.webkit.org/show_bug.cgi?24932 originally done by Thiago Macierira. It simply adds support for the Sun Studio Compiler.
Alexey Proskuryakov
Comment 2 2011-03-16 11:06:07 PDT
Comment on attachment 85903 [details] Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler View in context: https://bugs.webkit.org/attachment.cgi?id=85903&action=review > Source/JavaScriptCore/ChangeLog:6 > + Add a COMPILER(SUNCC) define for Sun Studio 12. Streamlined patch > + 1 of 16 originally from https://bugs.webkit.org/show_bug.cgi?id=24932 You need to provide an URL of this bug, not some other one. Doesn't matter all that much in this particular case, because there isn't a lot to look for in this bug.
Ben Taylor
Comment 3 2011-03-16 11:08:42 PDT
Happy to resubmit with a corrected ChangeLog. Let me know.
Ben Taylor
Comment 4 2011-03-16 11:37:29 PDT
Created attachment 85949 [details] Updated patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler Updated ChangeLog to correctly identify this bug and to also identify the derivation of the patch.
Alexey Proskuryakov
Comment 5 2011-03-17 10:52:58 PDT
Comment on attachment 85949 [details] Updated patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler Due to an e-mail exchange, I'm assuming that you intended to mark this for review.
WebKit Commit Bot
Comment 6 2011-03-17 13:04:58 PDT
The commit-queue encountered the following flaky tests while processing attachment 85949 [details]: http/tests/inspector/network/network-size.html bug 56581 (author: pfeldman@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2011-03-17 13:07:30 PDT
Comment on attachment 85949 [details] Updated patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler Clearing flags on attachment: 85949 Committed r81379: <http://trac.webkit.org/changeset/81379>
WebKit Commit Bot
Comment 8 2011-03-17 13:07:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.