Bug 55966

Summary: Factor out JNI method call to be used by both JSC and V8
Product: WebKit Reporter: Steve Block <steveblock>
Component: New BugsAssignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, commit-queue, eric, jorlow, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 55765, 55967    
Attachments:
Description Flags
Patch jorlow: review+, steveblock: commit-queue-

Steve Block
Reported 2011-03-08 14:11:47 PST
Factor out JNI method call to be used by both JSC and V8
Attachments
Patch (8.06 KB, patch)
2011-03-08 14:30 PST, Steve Block 		jorlow: review+
steveblock: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2011-03-08 14:30:18 PST
Created attachment 85090 [details] Patch
Jeremy Orlow
Comment 2 2011-03-08 21:04:12 PST
Comment on attachment 85090 [details] Patch r=me
Steve Block
Comment 3 2011-03-09 02:40:26 PST
Comment on attachment 85090 [details] Patch Will land manually
Steve Block
Comment 4 2011-03-09 03:09:57 PST
Committed r80633: <http://trac.webkit.org/changeset/80633>
Eric Seidel (no email)
Comment 5 2011-03-09 09:04:03 PST
Generallly if you race the cq, you'll always win. So unless you're making mods, you can just land manually,and the cq will eventually notice and silently abort any landing attempt it had in progress. If you're making changes when you land, it is possible (although unlikely) for the cq to win the race and it's good to remove the cq+ -- which will cause the cq to abort landing).
Note You need to log in before you can comment on or make changes to this bug.