Bug 55786

Summary:

JobjectWrapper should inherit from RefCounted rather than implementing its own ref counting

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Steve Block <steveblock>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

steveblock, tonyg

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

57859

Attachments:

Description	Flags
Patch	tonyg: review+

Steve Block

Reported 2011-03-04 10:45:31 PST

JobjectWrapper should inherit from RefCounted rather than implementing its own ref counting

Attachments
Patch (12.22 KB, patch) 2011-07-20 03:23 PDT, Steve Block	tonyg: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Steve Block

Comment 1 2011-07-20 03:23:02 PDT

Created attachment 101444 [details] Patch

Tony Gentilcore

Comment 2 2011-07-20 04:07:50 PDT

Comment on attachment 101444 [details] Patch Wow, awesome cleanup, thanks! Out of curiosity, were there any leaks/bugs here, does this improve perf due to less reference churn, or was this strictly just a maintainability thing? If one of the first two, might be interesting to mention in the ChangeLog.

Steve Block

Comment 3 2011-07-20 04:17:15 PDT

No, no functional change, just cleanup.

Steve Block

Comment 4 2011-07-20 04:20:24 PDT

Committed r91355: <http://trac.webkit.org/changeset/91355>

Steve Block

Comment 5 2011-07-20 08:50:43 PDT

This patch broke Mac builds: http://build.webkit.org/builders/SnowLeopard%20Intel%20Debug%20%28Build%29/builds/1387 http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Build%29/builds/37433 Speculative build fix landed: http://trac.webkit.org/changeset/91366

Note You need to log in before you can comment on or make changes to this bug.