Bug 54115

Created attachment 81827 [details] Proposed UA css change.

Comment on attachment 81827 [details] Proposed UA css change. Why do we need size="0" and size="1"?

(In reply to comment #2) > (From update of attachment 81827 [details]) > Why do we need size="0" and size="1"? We only want to change the popup's background but not the listbox. Select size="0"|"1" is select with popup. Other sizes would show up as listbox. The reason behind this is in http://crosbug.com/9174 @ comment 8. Web site might expect listbox background color go with the select element, something like in scrollbars/listbox-scrollbar-combinations.html. And I don't want to force them to do a "select option" rule to override UA css.

Comment on attachment 81827 [details] Proposed UA css change. I see, I read the bug here: http://code.google.com/p/chromium-os/issues/detail?id=9174 The size="0" bit seems like a hack. Where does the color for <option> background currently come from? Can we fix it there instead?

(In reply to comment #4) > (From update of attachment 81827 [details]) > I see, I read the bug here: http://code.google.com/p/chromium-os/issues/detail?id=9174 > > The size="0" bit seems like a hack. Where does the color for <option> background currently come from? Can we fix it there instead? It comes from the CSS like other element and if not specified (99.9% of the case), it will use its parent element's, which is the select element. I have checked with Dimitry and Tab but failed to find a CSS selector that could specifically target the select popup. :( And if we change the select element, it changes both the select as a button and as a listbox. I am not sure if that is okay.

Comment on attachment 81827 [details] Proposed UA css change. I see. It looks like html.css also uses select[size="0"] and select[size="1"] to force the menulist appearance, so this looks fine.

Comment on attachment 81827 [details] Proposed UA css change. Cool. Thanks for the quick review and checking it up. :)

Comment on attachment 81827 [details] Proposed UA css change. Clearing flags on attachment: 81827 Committed r78137: <http://trac.webkit.org/changeset/78137>

All reviewed patches have been landed. Closing bug.

The commit-queue encountered the following flaky tests while processing attachment 81827 [details]: http/tests/websocket/tests/handshake-fail-by-cross-origin.html bug 54147 (author: abarth@webkit.org) The commit-queue is continuing to process your patch.