Bug 54006

Summary: [Qt] Patch for compiling QtWebKit with WebGL (--3d-canvas) support
Product: WebKit Reporter: Dawit A. <adawit>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: benjamin
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch v1 none

Dawit A.
Reported 2011-02-08 08:26:56 PST
The attached patch fixes compilation of QtWebKit with WebGL support. Everything is straight forward except for the new file that was added to implement the draw buffering (platform/graphics/qt/DrawingBufferQt.cpp). Due to my lack of knowledge of 3D graphics programming, this newly added file, based on the chromium and mac ports, is there to simply ensure proper compilation and not proper functionality. More specifically the platform (Qt) specific layer support needs to be implemented for this class.
Attachments
proposed patch v1 (15.44 KB, patch)
2011-02-08 08:45 PST, Dawit A. 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dawit A.
Comment 1 2011-02-08 08:45:22 PST
Created attachment 81640 [details] proposed patch v1 Important note I forgot to mention was that the need to replace the function named "emit" with "emitChar" in "html/canvas/WebGLRenderingContext.cpp" arose from compilation failure due to conflict with Qt's signal/slot keyword.
Benjamin Poulain
Comment 2 2011-02-09 03:10:22 PST
Andrew Wason already started working on that on https://bugs.webkit.org/show_bug.cgi?id=53431 Dawit, it would be nice if you could sync with him. *** This bug has been marked as a duplicate of bug 53431 ***
Eric Seidel (no email)
Comment 3 2011-03-08 09:43:36 PST
Comment on attachment 81640 [details] proposed patch v1 Cleared review? from attachment 81640 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.