Bug 53001

Summary: m_mediaElement of MediaControlElement family should be removed.
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: MediaAssignee: Hajime Morrita <morrita>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: dglazkov, dominicc, rolandsteiner, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 52963    
Bug Blocks: 72352    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Hajime Morrita
Reported 2011-01-24 03:26:13 PST
These should be replaced with shadow root access API which will be introduced by Bug
Attachments
Patch (7.35 KB, patch)
2011-01-25 21:21 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (63.33 KB, patch)
2011-12-01 20:13 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (71.68 KB, patch)
2011-12-01 21:12 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2011-01-25 21:21:12 PST
Created attachment 80166 [details] Patch
Hajime Morrita
Comment 2 2011-01-25 21:23:04 PST
Hi Dimitri, could you could you take a look? I'd like to land this before your wave of changes arrives ;-o
Kent Tamura
Comment 3 2011-01-25 21:27:22 PST
Comment on attachment 80166 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80166&action=review > Source/WebCore/ChangeLog:14 > + * dom/Node.cpp: > + (WebCore::Node::shadowAncestorNode): Added const > + (WebCore::Node::shadowTreeRootNode): Added const Recently Darin Adler and Eric Seidel have told that const Nodes in WebCore make no sense. I guess they object this change. How about removing const from mediaElement() instead?
Dimitri Glazkov (Google)
Comment 4 2011-01-25 21:39:10 PST
I think Tamura-san's got this one! Also -- I am in the process of converting HTMLMediaElement. Can you take a different one, so that we don't step on each others toes? :)
Hajime Morrita
Comment 5 2011-01-25 21:49:29 PST
Comment on attachment 80166 [details] Patch Kent-san, Dimitri, thank you for take a look. OK, so I'll cancel this at now and wait Dimitri's change. Thanks for your suggestion!
Dominic Cooney
Comment 6 2011-11-20 17:46:38 PST
This should be a gimme now that media element conversion is done.
Hajime Morrita
Comment 7 2011-11-29 02:49:15 PST
I'm back.
Hajime Morrita
Comment 8 2011-12-01 20:13:45 PST
Created attachment 117550 [details] Patch
Hajime Morrita
Comment 9 2011-12-01 20:14:49 PST
Hi Dimitri, could you take a look? This change should be much trivial compared to the size of ChangeLog ;-)
WebKit Review Bot
Comment 10 2011-12-01 20:26:00 PST
Comment on attachment 117550 [details] Patch Attachment 117550 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10687863
Kent Tamura
Comment 11 2011-12-01 21:04:17 PST
Comment on attachment 117550 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117550&action=review r- because of Chromium build failure. > Source/WebCore/html/shadow/MediaControls.cpp:42 > + Element* host = toShadowRoot(shadowNode->shadowTreeRootNode())->shadowHost(); You can use Node::shadowAncestorNode().
Hajime Morrita
Comment 12 2011-12-01 21:12:18 PST
Created attachment 117560 [details] Patch
Hajime Morrita
Comment 13 2011-12-04 20:57:04 PST
Comment on attachment 117560 [details] Patch Similar change was landed: http://trac.webkit.org/changeset/101810
Hajime Morrita
Comment 14 2011-12-04 20:57:41 PST
http://trac.webkit.org/changeset/101810 Fixes this. *** This bug has been marked as a duplicate of bug 71410 ***
Note You need to log in before you can comment on or make changes to this bug.