Bug 52338

Summary: Cleanup WebGLGetInfo and related get*Parameter helpers in WebGLRenderingContext
Product: WebKit Reporter: Zhenyao Mo <zmo>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, enne, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 51908    
Bug Blocks:    
Attachments:
Description Flags
Patch kbr: review+

Zhenyao Mo
Reported 2011-01-12 17:08:44 PST
Currently for example, we have getLongParameter/getIntParameter/getUnsignedLongParameter, and according to GL type def, we actually should use int and unsigned int.
Attachments
Patch (26.81 KB, patch)
2011-01-24 16:42 PST, Zhenyao Mo 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2011-01-24 16:42:57 PST
Created attachment 79991 [details] Patch
Kenneth Russell
Comment 2 2011-01-24 17:23:48 PST
Comment on attachment 79991 [details] Patch Looks fine; should we be referencing GC3D typedefs?
Zhenyao Mo
Comment 3 2011-01-24 17:32:28 PST
I thought about using GC3D types, but then again, we already have Float32Array, Int8Array, ect, which are using generic types, so I didn't see a lot of benefits for using GC3Dint and GC3Duint.
Zhenyao Mo
Comment 4 2011-01-25 09:40:12 PST
Committed r76601: <http://trac.webkit.org/changeset/76601>
Note You need to log in before you can comment on or make changes to this bug.