Bug 52197

Summary: Use definition of PI from MathExtras.h
Product: WebKit Reporter: Carl Lobo <carllobo>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: berto
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
This patch uses the standard definitions of PI from MathExtras.h eric: commit-queue-

Carl Lobo
Reported 2011-01-10 22:46:24 PST
Removed redefinition of M_PI and replaced it with piDouble or piFloat as appropriate.
Attachments
This patch uses the standard definitions of PI from MathExtras.h (3.48 KB, patch)
2011-01-10 22:47 PST, Carl Lobo 		eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carl Lobo
Comment 1 2011-01-10 22:47:37 PST
Created attachment 78497 [details] This patch uses the standard definitions of PI from MathExtras.h
Eric Seidel (no email)
Comment 2 2011-01-11 03:03:06 PST
Comment on attachment 78497 [details] This patch uses the standard definitions of PI from MathExtras.h View in context: https://bugs.webkit.org/attachment.cgi?id=78497&action=review Looks great. But we need to fix the ChangeLog first or the commit-queue will fail to process it. > Source/WebCore/ChangeLog:7 > + Need a short description and bug URL (OOPS!) This will prevent the cq from being able to land this. the -b option to prepare-ChangeLog will fill this in automatically for you, or just using "webkit-patch upload" will fill it in too.
Adam Barth
Comment 3 2011-06-17 23:01:49 PDT
Comment on attachment 78497 [details] This patch uses the standard definitions of PI from MathExtras.h Please upload a new patch for the commit-queue.
Alberto Garcia
Comment 4 2013-10-09 15:13:08 PDT
*** This bug has been marked as a duplicate of bug 93109 ***
Note You need to log in before you can comment on or make changes to this bug.