Bug 51854

Summary:

[Qt] Default focus ring is too wide

Product:

WebKit

Reporter:

Yael <yael>

Component:

Accessibility

Assignee:

Alexis Menard (darktears) <menard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, menard, ossy

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

52612

Bug Blocks:

Attachments:

Description	Flags
Intermediate step: use QPalette::Highlight instead of black	none
Patch to fix the ugly focus ring	kling: review-
Patch to fix the ugly focus ring	none
Patch to fix the ugly focus ring	none

Yael

Reported 2011-01-03 16:33:29 PST

After http://trac.webkit.org/changeset/73362, the default focus ring in Qt is too wide. Some ideas of how to fix it: 1. Make the default configurable. 2. Use a gradient to draw the focus ring, like the mac port does, so it does not look so wide. 3. Not support the width of outline-width. 4. ???

Attachments
Intermediate step: use QPalette::Highlight instead of black (81.77 KB, patch) 2011-01-05 13:48 PST, Helder Correia	no flags	Details Formatted Diff Diff
Patch to fix the ugly focus ring (3.17 KB, patch) 2011-02-10 11:19 PST, Alexis Menard (darktears)	kling: review-	Details Formatted Diff Diff
Patch to fix the ugly focus ring (3.17 KB, patch) 2011-02-10 11:24 PST, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
Patch to fix the ugly focus ring (3.31 KB, patch) 2011-02-10 11:27 PST, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Helder Correia

Comment 1 2011-01-05 13:48:33 PST

Created attachment 78036 [details] Intermediate step: use QPalette::Highlight instead of black

Ariya Hidayat

Comment 2 2011-01-05 14:02:49 PST

Comment on attachment 78036 [details] Intermediate step: use QPalette::Highlight instead of black re=me

Yael

Comment 3 2011-01-05 14:50:27 PST

(In reply to comment #1) > Created an attachment (id=78036) [details] > Intermediate step: use QPalette::Highlight instead of black Thanks for doing this! I was looking for a QStyle API for color selection, and did not find any:( <https://bugs.webkit.org/show_bug.cgi?id=50325#c6>

WebKit Commit Bot

Comment 4 2011-01-05 18:17:09 PST

Comment on attachment 78036 [details] Intermediate step: use QPalette::Highlight instead of black Clearing flags on attachment: 78036 Committed r75126: <http://trac.webkit.org/changeset/75126>

WebKit Commit Bot

Comment 5 2011-01-05 18:17:15 PST

All reviewed patches have been landed. Closing bug.

Yael

Comment 6 2011-01-05 20:00:15 PST

This was an intermediate fix.

Yael

Comment 7 2011-01-18 08:52:45 PST

After https://bugs.webkit.org/show_bug.cgi?id=52612 is fixed, we could easily change the default width of the focus ring.

Alexis Menard (darktears)

Comment 8 2011-02-10 11:19:14 PST

Created attachment 82011 [details] Patch to fix the ugly focus ring This patch fix the ugly focus ring by ignoring the width if :focus has an outline set. Like many other ports we choose the nice looking option.

Andreas Kling

Comment 9 2011-02-10 11:23:20 PST

Comment on attachment 82011 [details] Patch to fix the ugly focus ring Needs ChangeLog. I agree with patch otherwise, our focus rings are way too ugly right now.

Alexis Menard (darktears)

Comment 10 2011-02-10 11:24:39 PST

Created attachment 82012 [details] Patch to fix the ugly focus ring This patch fix the ugly focus ring by ignoring the width if :focus has an outline set. Like many other ports we choose the nice looking option. Changelog for some weird reason was not in the diff.

Alexis Menard (darktears)

Comment 11 2011-02-10 11:27:07 PST

Created attachment 82013 [details] Patch to fix the ugly focus ring This patch fix the ugly focus ring by ignoring the width if :focus has an outline set. Like many other ports we choose the nice looking option. With ChangeLog

Andreas Kling

Comment 12 2011-02-10 11:40:31 PST

Comment on attachment 82013 [details] Patch to fix the ugly focus ring r=me

WebKit Commit Bot

Comment 13 2011-02-10 12:45:07 PST

Comment on attachment 82013 [details] Patch to fix the ugly focus ring Clearing flags on attachment: 82013 Committed r78259: <http://trac.webkit.org/changeset/78259>

WebKit Commit Bot

Comment 14 2011-02-10 12:45:13 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.