Bug 50023

Summary: [EFL] Remove adjacent tiles rendering queue
Product: WebKit Reporter: Alex Bredariol Grilo <abgrilo>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, antognolli+webkit, commit-queue, eric, jprvita, kenneth, kling, lucas.de.marchi, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 50456    
Attachments:
Description Flags
Patch
none
Patch none

Alex Bredariol Grilo
Reported 2010-11-24 07:30:39 PST
[EFL] Remove adjacent tiles rendering queue
Attachments
Patch (9.55 KB, patch)
2010-11-24 07:33 PST, Alex Bredariol Grilo 		no flags
DetailsFormatted DiffDiff
Patch (10.12 KB, patch)
2010-12-10 05:46 PST, Alex Bredariol Grilo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Bredariol Grilo
Comment 1 2010-11-24 07:33:36 PST
Created attachment 74758 [details] Patch
Lucas De Marchi
Comment 2 2010-12-06 03:36:59 PST
Comment on attachment 74758 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74758&action=review > WebKit/efl/ChangeLog:7 > + Could you give more details on what exactly you are doing? Is this a fix for a bug? > WebKit/efl/ChangeLog:20 > + And, please, detail the important changes above.
Alex Bredariol Grilo
Comment 3 2010-12-10 05:46:51 PST
Created attachment 76187 [details] Patch
Rafael Antognolli
Comment 4 2010-12-13 08:27:34 PST
(In reply to comment #3) > Created an attachment (id=76187) [details] > Patch Patch looks good to me.
Andreas Kling
Comment 5 2010-12-13 08:31:13 PST
Comment on attachment 76187 [details] Patch rs=me
WebKit Commit Bot
Comment 6 2010-12-13 10:09:37 PST
Comment on attachment 76187 [details] Patch Rejecting attachment 76187 [details] from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: pple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebKit.build/Release/WebKit.build/Objects-normal/x86_64/WebViewEventHandling.o /Projects/CommitQueue/WebKit/mac/WebView/WebViewEventHandling.mm normal x86_64 objective-c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebKit.build/Release/WebKit.build/Objects-normal/x86_64/WebView.o /Projects/CommitQueue/WebKit/mac/WebView/WebView.mm normal x86_64 objective-c++ com.apple.compilers.gcc.4_2 (41 failures) Full output: http://queues.webkit.org/results/7000098
Lucas De Marchi
Comment 7 2010-12-13 11:35:44 PST
(In reply to comment #6) > (From update of attachment 76187 [details]) > Rejecting attachment 76187 [details] from commit-queue. > > Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 > Last 500 characters of output: > pple.compilers.gcc.4_2 > CompileC /Projects/CommitQueue/WebKitBuild/WebKit.build/Release/WebKit.build/Objects-normal/x86_64/WebViewEventHandling.o /Projects/CommitQueue/WebKit/mac/WebView/WebViewEventHandling.mm normal x86_64 objective-c++ com.apple.compilers.gcc.4_2 > CompileC /Projects/CommitQueue/WebKitBuild/WebKit.build/Release/WebKit.build/Objects-normal/x86_64/WebView.o /Projects/CommitQueue/WebKit/mac/WebView/WebView.mm normal x86_64 objective-c++ com.apple.compilers.gcc.4_2 > (41 failures) > > I forgot the commit bot does not handle dependencies. Alex, could you rebase your patch and re-send it?
Eric Seidel (no email)
Comment 8 2010-12-13 11:39:11 PST
I'm not sure what you mean by "dependencies".
Lucas De Marchi
Comment 9 2010-12-13 12:01:39 PST
(In reply to comment #8) > I'm not sure what you mean by "dependencies". Sorry, I thought the error was that the patch didn't apply after patch in bug 50456 has landed. Actually the bug was with building mac port. Since this patch does not touch any file other than WebKit/efl/ewk/ewk_tiled_backing_store.c, maybe it's safe to cq+ again?
Lucas De Marchi
Comment 10 2010-12-13 12:55:03 PST
Comment on attachment 76187 [details] Patch let's try again.
WebKit Commit Bot
Comment 11 2010-12-13 15:00:16 PST
Comment on attachment 76187 [details] Patch Rejecting attachment 76187 [details] from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: l x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebKit2.build/Release/WebKit2.build/Objects-normal/x86_64/WebProcessProxy.o /Projects/CommitQueue/WebKit2/UIProcess/WebProcessProxy.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebKit2.build/Release/WebKit2.build/Objects-normal/x86_64/WebPage.o /Projects/CommitQueue/WebKit2/WebProcess/WebPage/WebPage.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (6 failures) Full output: http://queues.webkit.org/results/6938121
Eric Seidel (no email)
Comment 12 2010-12-13 15:07:11 PST
Comment on attachment 76187 [details] Patch Clearly one of the cq nodes is having trouble. Not sure why.
WebKit Commit Bot
Comment 13 2010-12-13 15:44:14 PST
Comment on attachment 76187 [details] Patch Rejecting attachment 76187 [details] from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: itQueue/WebKitBuild/WebKit2.build/Release/WebKit2.build/Objects-normal/x86_64/AuthenticationChallengeProxy.o /Projects/CommitQueue/WebKit2/UIProcess/Authentication/AuthenticationChallengeProxy.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebKit2.build/Release/WebKit2.build/Objects-normal/x86_64/WebDatabaseManagerProxy.o /Projects/CommitQueue/WebKit2/UIProcess/WebDatabaseManagerProxy.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (13 failures) Full output: http://queues.webkit.org/results/6975095
Eric Seidel (no email)
Comment 14 2010-12-13 15:46:56 PST
I'm really not sure what's going on here. Maybe my commit bot node has been failing constantly for all patches? I'm not sure how this one failed 3 times in a row like that?
Lucas De Marchi
Comment 15 2010-12-13 17:28:30 PST
Comment on attachment 76187 [details] Patch Clearing flags on attachment: 76187 Committed r73990: <http://trac.webkit.org/changeset/73990>
Lucas De Marchi
Comment 16 2010-12-13 17:28:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.