Bug 48257

Summary: Make "rl" and "bt" writing-modes work for blocks and lines.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46123    
Attachments:
Description Flags
Patch mitz: review+

Dave Hyatt
Reported 2010-10-25 12:18:54 PDT
Make "rl" and "bt" writing-modes work for blocks and lines. This is just the basics. Repainting and invalidation aren't right yet.
Attachments
Patch (102.97 KB, patch)
2010-10-25 12:21 PDT, Dave Hyatt 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-10-25 12:21:33 PDT
Created attachment 71781 [details] Patch
mitz
Comment 2 2010-10-25 12:29:29 PDT
Comment on attachment 71781 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71781&action=review > WebCore/rendering/InlineBox.h:293 > + void adjustForFlippedBlocksWritingMode(int& x, int& y); It’s sad the we keep adding (int, int) methods instead of IntPoint methods. > WebCore/rendering/InlineTextBox.cpp:904 > +void InlineTextBox::paintTextMatchMarker(GraphicsContext* pt, const IntPoint& boxOrigin, const DocumentMarker& marker, RenderStyle* style, const Font& font) Extra space before const IntPoint
Dave Hyatt
Comment 3 2010-10-25 13:06:32 PDT
Fixed in r70482. I changed the adjust functions to take points instead of two ints.
Note You need to log in before you can comment on or make changes to this bug.