Bug 45165

Created attachment 66475 [details] Patch

is there a way to reuse fileSystemEnabled()? i know that [EnableAtRuntime] requires a getter with a specific name, but i think in this case it might be better to write some custom code to reuse fileSystemEnabled() (if possible).

Comment on attachment 66475 [details] Patch Removing this from the review queue for now as we may not need to expose Flags (sent an email about this to public-webapps). (Thanks dumi for your review comment!)

Created attachment 67133 [details] Patch Reviving this patch.

Created attachment 67135 [details] Patch

Created attachment 67147 [details] Patch

(In reply to comment #2) > is there a way to reuse fileSystemEnabled()? i know that [EnableAtRuntime] requires a getter with a specific name, but i think in this case it might be better to write some custom code to reuse fileSystemEnabled() (if possible). I added custom getter for V8 (since EnableAtRuntime is valid only in V8). This doesn't stop exposing Flags constructor Window though -- I wasn't able to find a way to hook the custom code from the DOMWindow's prototype template constructor method.

Created attachment 67150 [details] Patch Modified the code generator to take additional parameter to EnableAtRuntime so that we can reuse fileSystemEnabled().

Created attachment 67159 [details] Patch Rebased.

Comment on attachment 67159 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=67159&action=prettypatch r=me. please address the comment before landing. > WebCore/bindings/scripts/CodeGeneratorV8.pm:3395 > + if (length($signature->extendedAttributes->{"EnabledAtRuntime"}) > 1) { to keep this function consistent with all other helper functions, i think we should change its format to: return "RuntimeEnabledFeatures::" . $codeGenerator->WK_lcfirst($signature->extendedAttributes->{"EnabledAtRuntime"}) . "Enabled" if ($signature->extendedAttributes->{"EnabledAtRuntime"} ne ""); return <the default name>;

(In reply to comment #10) > (From update of attachment 67159 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=67159&action=prettypatch > > > WebCore/bindings/scripts/CodeGeneratorV8.pm:3395 > > + if (length($signature->extendedAttributes->{"EnabledAtRuntime"}) > 1) { > to keep this function consistent with all other helper functions, i think we should change its format to: > > return "RuntimeEnabledFeatures::" . $codeGenerator->WK_lcfirst($signature->extendedAttributes->{"EnabledAtRuntime"}) . "Enabled" if ($signature->extendedAttributes->{"EnabledAtRuntime"} ne ""); > return <the default name>; As extendedAttributes->{"EnabledAtRuntime"} has value 1 when it's set but has no values, I'm going to make the if expr look like following. (Could you ping me if it doesn't look good.) Thanks, > return ... if ($signature->extendedAttributes->{"EnabledAtRuntime"} && $signature->extendedAttributes->{"EnabledAtRuntime"} != 1);

Committed r67421: <http://trac.webkit.org/changeset/67421>