Bug 41437

Summary: Add interface for network platform to pass up timing information
Product: WebKit Reporter: Tony Gentilcore <tonyg>
Component: New BugsAssignee: Tony Gentilcore <tonyg>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, fishd
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 30685    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Tony Gentilcore
Reported 2010-06-30 16:40:32 PDT
Add interface for network platform to pass up timing information
Attachments
Patch (14.99 KB, patch)
2010-06-30 19:03 PDT, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.99 KB, patch)
2010-06-30 21:51 PDT, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.96 KB, patch)
2010-07-01 11:53 PDT, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tony Gentilcore
Comment 1 2010-06-30 19:03:57 PDT
Created attachment 60183 [details] Patch
Adam Barth
Comment 2 2010-06-30 20:28:14 PDT
Comment on attachment 60183 [details] Patch Why a RefPtr and not an OwnPtr? I didn't see any sharing, but I might have missed it. WebCore/platform/network/ResourceLoadTiming.h:44 + RefPtr<ResourceLoadTiming> timing(create()); we usually use the = form
Tony Gentilcore
Comment 3 2010-06-30 20:40:07 PDT
(In reply to comment #2) > (From update of attachment 60183 [details]) > Why a RefPtr and not an OwnPtr? I didn't see any sharing, but I might have missed it. ResourceResponseBase is copyable, but OwnPtr is not. So it can't have OwnPtr members. This patch follows the pattern of FormData on ResourceRequestBase. > > WebCore/platform/network/ResourceLoadTiming.h:44 > + RefPtr<ResourceLoadTiming> timing(create()); > we usually use the = form OK
Adam Barth
Comment 4 2010-06-30 20:41:42 PDT
Comment on attachment 60183 [details] Patch Ah, thanks. I'm not 100% clear on the motivation for this change, but the code itself looks fine.
Tony Gentilcore
Comment 5 2010-06-30 20:54:51 PDT
(In reply to comment #4) > (From update of attachment 60183 [details]) > Ah, thanks. I'm not 100% clear on the motivation for this change, but the code itself looks fine. I'm implementing: http://dev.w3.org/2006/webapi/WebTiming/ Some of the timings can be measures solely in WebKit. Those are in https://bugs.webkit.org/show_bug.cgi?id=41332 The rest of the timings have to be passed up from the network platform. That is what this is for.
Tony Gentilcore
Comment 6 2010-06-30 21:51:26 PDT
Created attachment 60192 [details] Patch for landing
WebKit Commit Bot
Comment 7 2010-07-01 01:33:05 PDT
Comment on attachment 60192 [details] Patch for landing Rejecting patch 60192 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Last 500 characters of output: hing file WebCore/WebCore.vcproj/WebCore.vcproj patching file WebCore/WebCore.xcodeproj/project.pbxproj Hunk #2 succeeded at 7972 (offset 2 lines). Hunk #3 succeeded at 12041 (offset 4 lines). Hunk #4 FAILED at 19668. 1 out of 4 hunks FAILED -- saving rejects to file WebCore/WebCore.xcodeproj/project.pbxproj.rej patching file WebCore/platform/network/ResourceLoadTiming.h patching file WebCore/platform/network/ResourceResponseBase.cpp patching file WebCore/platform/network/ResourceResponseBase.h Full output: http://webkit-commit-queue.appspot.com/results/3373083
Tony Gentilcore
Comment 8 2010-07-01 11:53:57 PDT
Created attachment 60267 [details] Patch for landing
WebKit Commit Bot
Comment 9 2010-07-01 19:22:55 PDT
Comment on attachment 60267 [details] Patch for landing Clearing flags on attachment: 60267 Committed r62348: <http://trac.webkit.org/changeset/62348>
WebKit Commit Bot
Comment 10 2010-07-01 19:23:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.