Bug 40512

Summary: Fix the rest of the references to the old Tokenizer class (now DocumentParser)
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, mjs
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 40491    
Attachments:
Description Flags
Patch
none
Patch for landing none

Eric Seidel (no email)
Reported 2010-06-11 18:18:43 PDT
Fix the rest of the references to the old Tokenizer class (now DocumentParser)
Attachments
Patch (50.67 KB, patch)
2010-06-11 18:24 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (54.74 KB, patch)
2010-06-13 17:20 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-06-11 18:24:19 PDT
Created attachment 58534 [details] Patch
Maciej Stachowiak
Comment 2 2010-06-11 18:48:16 PDT
Some questions from IRC review: 1) Is there a need to rename the existing parser classes before they are ready to be phased out? 2) Should XMLTokenizer* be renamed too? 3) Likewise the various Tokenizer helper classes in the loader/ directory for handling tree building for non-HTML non-XML types (TextTokenizer, PluginTokenizer, MediaTokenizer, ImageTokenizer, maybe more I am missing).
WebKit Commit Bot
Comment 3 2010-06-12 04:06:13 PDT
Comment on attachment 58534 [details] Patch Rejecting patch 58534 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Last 500 characters of output: t.h patching file WebCore/loader/TextDocument.cpp Hunk #1 FAILED at 183. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/loader/TextDocument.cpp.rej patching file WebCore/loader/TextDocument.h patching file WebCore/svg/SVGDocumentExtensions.cpp patching file WebCore/wml/WMLDocument.cpp patching file WebCore/wml/WMLErrorHandling.cpp Hunk #1 FAILED at 38. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/wml/WMLErrorHandling.cpp.rej patching file WebCore/wml/WMLTemplateElement.cpp Full output: http://webkit-commit-queue.appspot.com/results/3257227
WebKit Commit Bot
Comment 4 2010-06-13 00:03:40 PDT
Comment on attachment 58534 [details] Patch Rejecting patch 58534 from commit-queue. Unexpected failure when processing patch! Please file a bug against webkit-patch. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 58534, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: date_status return NetworkTransaction().run(lambda: self._post_status_to_server(queue_name, status, patch, results_file)) File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/net/networktransaction.py", line 56, in run self._check_for_timeout() File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/net/networktransaction.py", line 63, in _check_for_timeout raise NetworkTimeout() webkitpy.common.net.networktransaction.NetworkTimeout
Eric Seidel (no email)
Comment 5 2010-06-13 17:20:53 PDT
Created attachment 58605 [details] Patch for landing
Adam Barth
Comment 6 2010-06-13 21:40:31 PDT
Comment on attachment 58605 [details] Patch for landing Clearing flags on attachment: 58605 Committed r61104: <http://trac.webkit.org/changeset/61104>
Adam Barth
Comment 7 2010-06-13 21:40:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.