Bug 31037

Summary:

committers.py needs a way to store non-bugzilla email addresses

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

30970

Attachments:

Description	Flags
Add code to support bug 30970	none
Add code to support bug 30970	none
Updated patch. Flattened emails into one list.	none

Eric Seidel (no email)

Reported 2009-11-02 17:56:38 PST

committers.py needs a way to store non-bugzilla email addresses This is needed by the validate-committer-lists script attached to bug 30970. I'm breaking this out into a separate bug in hopes of making review/commit easier.

Attachments
Add code to support bug 30970 (3.52 KB, patch) 2009-11-02 18:07 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Add code to support bug 30970 (5.29 KB, patch) 2009-11-02 18:10 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Updated patch. Flattened emails into one list. (6.68 KB, patch) 2009-11-03 13:43 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2009-11-02 18:07:27 PST

Created attachment 42353 [details] Add code to support bug 30970

Eric Seidel (no email)

Comment 2 2009-11-02 18:10:56 PST

Created attachment 42354 [details] Add code to support bug 30970

Mark Rowe (bdash)

Comment 3 2009-11-02 19:12:15 PST

IMO we should be treating the address used for committing as the “real” address, not the Bugzilla one.

Eric Seidel (no email)

Comment 4 2009-11-03 00:15:12 PST

I think it might make sense to just make all email addresses equal. I think I'll change it to be one flat list instead of having a special separate bugzilla email address. As long as it's impossible to create an account with bugzilla that points to an email address you don't own, then having a flat list should work just fine.

Eric Seidel (no email)

Comment 5 2009-11-03 01:02:12 PST

I think I'll make it a flat list of emails, and possibly will have a separate flat list for expired emails. Expired emails may not be necessary for active contributers, I'm not sure. If I ever end up landing the rest of bug 26533 then we'll need more storage options for committers.py.

Eric Seidel (no email)

Comment 6 2009-11-03 13:43:41 PST

Created attachment 42414 [details] Updated patch. Flattened emails into one list.

Adam Barth

Comment 7 2009-11-04 00:09:10 PST

Comment on attachment 42414 [details] Updated patch. Flattened emails into one list. The zeroth email is still special, but other than that this looks good. Maybe consider__str__ listing all the emails?

Eric Seidel (no email)

Comment 8 2009-11-04 00:11:16 PST

I had __str__ listing all the emails in a previous draft and it looked strange. I agree, the 0th email shouldn't really be special. but __str__ is just supposed to give you some idea what the record is, and it not really meant to be a full serialization of the object. I think it's OK for 0 to be "special" in this way for now. I'm sad that this patch looses the data of what email addresses are valid bugzilla addresses, but I don't think we really need that information. If we later need it, it will be easy to re-acquire with a little scripting. Thanks for the review.

WebKit Commit Bot

Comment 9 2009-11-04 01:16:07 PST

Comment on attachment 42414 [details] Updated patch. Flattened emails into one list. Clearing flags on attachment: 42414 Committed r50505: <http://trac.webkit.org/changeset/50505>

WebKit Commit Bot

Comment 10 2009-11-04 01:16:14 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.