Bug 270047

Summary:	[Skia] Do not use the legacy native GL/EGL interface factory
Product:	WebKit	Reporter:	Adrian Perez <aperez>
Component:	Layout and Rendering	Assignee:	Adrian Perez <aperez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	268972

Adrian Perez

Reported 2024-02-25 02:28:35 PST

Skia is slowly transitioning away from the implicit instantiation of its GL/EGL interface helpers via GrGLMakeNativeInterface(), which I have been made aware of in a comment here: https://skia-review.googlesource.com/c/skia/+/814176/comment/dc3041af_dbaf1a16/ From the WebKit side what we need to do is explicitly passing a GrGLInterface which we have explicitly created when using GrDirectContext::MakeGL()

Attachments
Add attachment proposed patch, testcase, etc.

Adrian Perez

Comment 1 2024-02-25 02:39:33 PST

Pull request: https://github.com/WebKit/WebKit/pull/25069

EWS

Comment 2 2024-02-26 00:13:32 PST

Committed 275311@main (c6ffba680732): <https://commits.webkit.org/275311@main> Reviewed commits have been landed. Closing PR #25069 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2024-02-26 00:14:15 PST

<rdar://problem/123618141>

Note You need to log in before you can comment on or make changes to this bug.