Bug 266044
| Summary: | REGRESSION: run-api-tests strips newlines in failure summary | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, jbedard, ryanhaddad, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Timothy Hatcher
This seems to be a recent-ish regression, I definitely it formatting the results much nicer. (The inline results during the tests look fine, it is just the summary.)
Example summary:
webkit-extension://9cf23198-e1ce-4b7a-a478-cad199dead28/background.js:17Title should be provided after same site navigation: Actual: undefinedExpected: "Next Title"
(edited)
Inline result:
webkit-extension://097ed562-83de-477d-b107-9dfbc06db7f1/background.js:17
Title should be provided after same site navigation:
Actual: undefined
Expected: "Next Title"
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
It's not clear to me what this describes, I don't see output of this kind at https://build.webkit.org/#/builders/933/builds/569/steps/19/logs/stdio. Could you please post a link?
Ryan Haddad
(In reply to Alexey Proskuryakov from comment #1)
> It's not clear to me what this describes, I don't see output of this kind at
> https://build.webkit.org/#/builders/933/builds/569/steps/19/logs/stdio.
> Could you please post a link?
I think it is actually visible in the link you shared, see:
/Volumes/Data/worker/Apple-Sonoma-Debug-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIRuntime.mm:877
Expected equality of these values:
manager.get().yieldMessage
Which is: Startup Event Did Not Fire
@"Startup Event Fired"
Which is: Startup Event Fired
but in the summary:
TestWebKitAPI.WKWebExtensionAPIRuntime.StartupEvent
/Volumes/Data/worker/Apple-Sonoma-Debug-Build/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIRuntime.mm:877Expected equality of these values: manager.get().yieldMessage Which is: Startup Event Did Not Fire @"Startup Event Fired" Which is: Startup Event FiredLEAK: 2 WebProcessPoolLEAK: 2 WebPageProxy
Alexey Proskuryakov
Indeed.
Radar WebKit Bug Importer
<rdar://problem/119696758>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/28402
EWS
Committed 278660@main (11b43d3c00be): <https://commits.webkit.org/278660@main>
Reviewed commits have been landed. Closing PR #28402 and removing active labels.