Bug 235665

Summary: Add copy-to-clipboard button for fuzzy matching meta tag
Product: WebKit Reporter: Jon Lee <jonlee>
Component: Tools / TestsAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, glenn, gsnedders, jbedard, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=231828
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch darin: review+

Jon Lee
Reported 2022-01-26 12:36:14 PST
.
Attachments
Patch (4.62 KB, patch)
2022-01-26 12:41 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (2.43 KB, patch)
2022-01-26 13:55 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (2.60 KB, patch)
2022-01-26 16:32 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (3.28 KB, patch)
2022-01-26 20:26 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (3.28 KB, patch)
2022-01-26 20:41 PST, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (3.28 KB, patch)
2022-01-26 23:28 PST, Jon Lee 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Jon Lee
Comment 1 2022-01-26 12:41:12 PST
Created attachment 450058 [details] Patch
Simon Fraser (smfr)
Comment 2 2022-01-26 13:13:59 PST
Comment on attachment 450058 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450058&action=review > Tools/Scripts/webkitpy/layout_tests/models/test_failures.py:217 > + return 'maxDifference=0-{}; totalPixels=0-{}'.format(fuzzy_data['max_difference'], fuzzy_data['total_pixels']) I worry that this is going to encourage 0-N ranges for all time, in all contexts. We really only want it for tests affected by accelerated drawing.
Jon Lee
Comment 3 2022-01-26 13:55:44 PST
Created attachment 450066 [details] Patch
Jon Lee
Comment 4 2022-01-26 16:32:05 PST
Created attachment 450082 [details] Patch
Simon Fraser (smfr)
Comment 5 2022-01-26 20:14:36 PST
Need new results for the layout test that is also the diff page.
Jon Lee
Comment 6 2022-01-26 20:26:39 PST
Created attachment 450098 [details] Patch
Jon Lee
Comment 7 2022-01-26 20:41:24 PST
Created attachment 450099 [details] Patch
Jon Lee
Comment 8 2022-01-26 23:28:51 PST
Created attachment 450105 [details] Patch
Darin Adler
Comment 9 2022-01-27 16:39:07 PST
Comment on attachment 450105 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450105&action=review rs=me > LayoutTests/ChangeLog:11 > + * fast/harness/image-diff-template-expected.txt: Maybe at some point we can move this harness into a "resources" directory so we don’t have to also run it as a test?
Simon Fraser (smfr)
Comment 10 2022-01-27 16:41:20 PST
I think running it as a test is a "feature".
Jon Lee
Comment 11 2022-01-28 10:09:36 PST
Committed r288745 (246538@trunk): <https://commits.webkit.org/246538@trunk>
Radar WebKit Bug Importer
Comment 12 2022-01-28 10:10:17 PST
<rdar://problem/88191824>
Note You need to log in before you can comment on or make changes to this bug.