Bug 229402

Summary: WebGL calls into static GraphicsContextGLOpenGL functions needlessly
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 229404    
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing none

Kimmo Kinnunen
Reported 2021-08-23 03:24:05 PDT
WebGL calls into static GraphicsContextGLOpenGL functions needlessly The calls are problematic: * No other call sites than WebGL layer * The functionality is not needed for ANGLE, but present * GraphicsContextGL is now an interface with multiple implementations, GraphicsContextGLOpenGL is just one implementation
Attachments
Patch (30.02 KB, patch)
2021-08-23 03:29 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (33.60 KB, patch)
2021-08-23 04:28 PDT, Kimmo Kinnunen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (33.49 KB, patch)
2021-08-23 04:31 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch for landing (33.76 KB, patch)
2021-08-25 00:19 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-08-23 03:29:15 PDT
Created attachment 436178 [details] Patch
Kimmo Kinnunen
Comment 2 2021-08-23 04:28:06 PDT
Created attachment 436184 [details] Patch
Kimmo Kinnunen
Comment 3 2021-08-23 04:31:57 PDT
Created attachment 436185 [details] Patch
Kenneth Russell
Comment 4 2021-08-23 18:12:04 PDT
Comment on attachment 436185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436185&action=review Looks good in principle; I didn't look into the failures on the platforms not yet using ANGLE. Hopefully they won't be hard to figure out. r+ > Source/WebCore/html/canvas/WebGLFramebuffer.cpp:409 > +#endif Now might be a good time to add comments to the #endifs like: #endif // !USE(ANGLE) because it's hard to see what it matches up with once these blocks span multiple lines of code. > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:639 > #endif Please consider commenting the #endifs to make them easier to read.
Kimmo Kinnunen
Comment 5 2021-08-25 00:19:10 PDT
Created attachment 436373 [details] Patch for landing
EWS
Comment 6 2021-08-26 05:46:04 PDT
Committed r281621 (240977@main): <https://commits.webkit.org/240977@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436373 [details].
Radar WebKit Bug Importer
Comment 7 2021-08-26 05:47:16 PDT
<rdar://problem/82385595>
Note You need to log in before you can comment on or make changes to this bug.