Bug 227493

Summary:

Support <dialog> element close event

Product:

WebKit

Reporter:

Tim Nguyen (:ntim) <ntim>

Component:

DOM

Assignee:

Tim Nguyen (:ntim) <ntim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, darin, dbarton, esprehn+autocc, ews-watchlist, fred.wang, gyuyoung.kim, kangil.han, koivisto, kondapallykalyan, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

84635, 227915

Attachments:

Description	Flags
Patch	none
Patch	none

Tim Nguyen (:ntim)

Reported 2021-06-29 10:54:31 PDT

The <dialog> element should emit a "close" event. https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement/close_event https://html.spec.whatwg.org/multipage/indices.html#event-close

Attachments
Patch (61.96 KB, patch) 2021-06-30 01:39 PDT, Tim Nguyen (:ntim)	no flags	Details Formatted Diff Diff
Patch (76.98 KB, patch) 2021-06-30 02:32 PDT, Tim Nguyen (:ntim)	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-06-29 23:55:16 PDT

<rdar://problem/79952910>

Tim Nguyen (:ntim)

Comment 2 2021-06-30 01:39:02 PDT

Created attachment 432575 [details] Patch

Antti Koivisto

Comment 3 2021-06-30 01:56:49 PDT

Comment on attachment 432575 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432575&action=review > Source/WebCore/html/HTMLDialogElement.h:28 > +#include "EventSender.h" You can forward declare EventSender with template<typename T> class EventSender; so you don't need this include in the header (slightly reducing header bloat and so improving compile times). See the other EventSenders. > Source/WebCore/html/HTMLDialogElement.h:33 > +typedef EventSender<HTMLDialogElement> DialogEventSender; Modern replacement for typedef is using: using DialogEventSender = EventSender<HTMLDialogElement>; I find it more readable. > Source/WebCore/html/HTMLDialogElement.h:57 > - void toggleOpen(); > + void toggleOpen(bool newValue); This should be renamed to setOpen since it is now a setter rather than a toggle. No need for parameter name, it is obvious from context.

Tim Nguyen (:ntim)

Comment 4 2021-06-30 02:32:31 PDT

Created attachment 432578 [details] Patch

EWS

Comment 5 2021-06-30 03:18:34 PDT

Committed r279406 (239271@main): <https://commits.webkit.org/239271@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432578 [details].

Darin Adler

Comment 6 2021-07-01 14:02:42 PDT

Comment on attachment 432575 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432575&action=review >> Source/WebCore/html/HTMLDialogElement.h:28 >> +#include "EventSender.h" > > You can forward declare EventSender with > > template<typename T> class EventSender; > > so you don't need this include in the header (slightly reducing header bloat and so improving compile times). See the other EventSenders. In fact, can do this: template<typename> class EventSender;

Note You need to log in before you can comment on or make changes to this bug.