Bug 218706

Summary: [build.webkit.org] Add python 3 support - part 3
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, dewei_zhu, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 175056    
Attachments:
Description Flags
Patch
none
Patch none

Aakash Jain
Reported 2020-11-09 06:35:43 PST
Python 3 support is required for Buildbot 2+. Part 1 and 2 of this change were in: https://bugs.webkit.org/show_bug.cgi?id=217727 and https://bugs.webkit.org/show_bug.cgi?id=218130
Attachments
Patch (6.63 KB, patch)
2020-11-09 06:45 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (6.67 KB, patch)
2020-11-09 06:49 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-11-09 06:45:14 PST
Created attachment 413581 [details] Patch
Aakash Jain
Comment 2 2020-11-09 06:49:40 PST
Created attachment 413582 [details] Patch
Jonathan Bedard
Comment 3 2020-11-09 08:30:35 PST
Comment on attachment 413582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413582&action=review > Tools/CISupport/build-webkit-org/loadConfig.py:-189 > - keywords = filter(None, re.split('[, \-_:()]+', str(builder['name']))) Seems like code that results in the what the original code is would be: keywords = re.split('[, \-_:()]+', str(builder['name'])) or None But it likely doesn't matter.
EWS
Comment 4 2020-11-09 08:41:42 PST
Committed r269581: <https://trac.webkit.org/changeset/269581> All reviewed patches have been landed. Closing bug and clearing flags on attachment 413582 [details].
Radar WebKit Bug Importer
Comment 5 2020-11-09 08:42:20 PST
<rdar://problem/71193363>
Note You need to log in before you can comment on or make changes to this bug.