Bug 218180
| Summary: | Remove uses of "direct" functions from WebGL | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> |
| Component: | WebGL | Assignee: | Kimmo Kinnunen <kkinnunen> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dino, jonlee, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | All | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=217211 | ||
Kimmo Kinnunen
Remove uses of "direct" functions from WebGL
WebGL implementation calls to GraphicsContextGLOpenGL functions that end with "Impl" or "Direct".
These are functions that are trying to jump around either:
a) ANGLE shader translator behavior when USE(OPENGL) / USE(OPENGL_ES)
b) WebGL validation / robust behavior when in ANGLE
Neither of these are valid use-cases for the actual WebGL implementation and as such shouldn't exist as part of WebGL implementation nor the GraphicsContextGL abstraction.
Remove or limit them to places where the concrete GraphicsContextGLOpenGL implementation is logically used.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/70684393>
Kimmo Kinnunen
Marking this as fixed, the direct function variants were gradually removed by other refactoring commits.