Bug 217790

Summary: [WebAuthn] Move AppAttestInternal related code from WKA to OpenSource
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, ews-watchlist, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch
bfulgham: review+, ews-feeder: commit-queue-
Patch for Landing none

Jiewen Tan
Reported 2020-10-15 15:53:04 PDT
Move AppAttestInternal related code from WKA to OpenSource.
Attachments
Patch (14.77 KB, patch)
2020-10-15 15:57 PDT, Jiewen Tan 		bfulgham: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for Landing (17.78 KB, patch)
2020-10-15 23:17 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2020-10-15 15:53:29 PDT
<rdar://problem/59613406>
Jiewen Tan
Comment 2 2020-10-15 15:57:32 PDT
Created attachment 411503 [details] Patch
Brent Fulgham
Comment 3 2020-10-15 16:20:49 PDT
Comment on attachment 411503 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411503&action=review r=mews > Source/WebKit/UIProcess/WebAuthentication/Cocoa/AppAttestInternalSoftLink.h:28 > +#import <wtf/SoftLinking.h> I wonder if you need this if APPLE_ATTESTATION is not defined? > Source/WebKit/UIProcess/WebAuthentication/Cocoa/AppAttestInternalSoftLink.mm:28 > +#import <wtf/SoftLinking.h> I wonder if you even need to include this if the build does not have APPLE_ATTESTATION defined?
Brent Fulgham
Comment 4 2020-10-15 16:21:03 PDT
Looks good, bug please wait for EWS to complete before landing.
Jiewen Tan
Comment 5 2020-10-15 16:54:43 PDT
(In reply to Brent Fulgham from comment #4) > Looks good, bug please wait for EWS to complete before landing. Forgot to add a SPI file. Will upload a patch with that... Thanks for r+!
Jiewen Tan
Comment 6 2020-10-15 23:14:42 PDT
Comment on attachment 411503 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411503&action=review >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/AppAttestInternalSoftLink.h:28 >> +#import <wtf/SoftLinking.h> > > I wonder if you need this if APPLE_ATTESTATION is not defined? Fixed. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/AppAttestInternalSoftLink.mm:28 >> +#import <wtf/SoftLinking.h> > > I wonder if you even need to include this if the build does not have APPLE_ATTESTATION defined? Fixed.
Jiewen Tan
Comment 7 2020-10-15 23:17:10 PDT
Created attachment 411537 [details] Patch for Landing
Jiewen Tan
Comment 8 2020-10-16 00:52:51 PDT
Committed r268575: <https://trac.webkit.org/changeset/268575>
Note You need to log in before you can comment on or make changes to this bug.