Bug 215016

Summary: [LFC][IFC] LineBuilder should not align the runs
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 215087, 215752    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

alan
Reported 2020-07-31 05:15:11 PDT
LineBuilder is responsible for adding content to the line but the alignment (horizontal/vertical) should be done by the LineBox.
Attachments
Patch (48.36 KB, patch)
2020-07-31 05:19 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (48.74 KB, patch)
2020-08-26 10:16 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (48.74 KB, patch)
2020-08-26 12:16 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (48.70 KB, patch)
2020-08-26 19:26 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2020-07-31 05:19:09 PDT
Created attachment 405681 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-08-07 05:16:18 PDT
<rdar://problem/66675537>
alan
Comment 3 2020-08-26 10:16:04 PDT
Created attachment 407309 [details] Patch
alan
Comment 4 2020-08-26 12:16:18 PDT
Created attachment 407319 [details] Patch
EWS
Comment 5 2020-08-26 19:23:46 PDT
ChangeLog entry in Source/WebCore/ChangeLog is not at the top of the file.
alan
Comment 6 2020-08-26 19:26:24 PDT
Created attachment 407369 [details] Patch
EWS
Comment 7 2020-08-26 21:36:42 PDT
Committed r266222: <https://trac.webkit.org/changeset/266222> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407369 [details].
Note You need to log in before you can comment on or make changes to this bug.