Bug 212950

Summary: [WebDriver][WPE] Support creating new webviews from create-web-view signal
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: WPE WebKitAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, bugs-noreply, ews-watchlist, gyuyoung.kim, karlcow, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: BrowserCompat
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 216899    
Attachments:
Description Flags
WIP without touch and cleanup support none

Lauro Moura
Reported 2020-06-08 20:21:03 PDT
Originally, bug 212118 was created to allow MB to create new views for some WebDriver tests from the "create" signal in child views, and fixed a number of failures. But "POST /session/{session_id}/window/new" implementation emits "create-web-view". WPE's MiniBrowser handler for it only returns the original automated webview instead of creating a new one. This is is causing a number of w3c/tests/new_window/user_prompts.py to fail.
Attachments
WIP without touch and cleanup support (40.95 KB, patch)
2020-10-28 23:15 PDT, Lauro Moura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2020-10-28 23:15:08 PDT
Created attachment 412615 [details] WIP without touch and cleanup support With this patch, a lot of new WebDriver failures related to the session fixure from W3C tests are working now. Still missing touch support, styling changes and sorting out the cleanup, but uploading for initial feedback.
Lauro Moura
Comment 2 2024-06-23 21:34:57 PDT
Pull request: https://github.com/WebKit/WebKit/pull/30103
EWS
Comment 3 2024-07-01 07:12:47 PDT
Committed 280534@main (474a4428f7ed): <https://commits.webkit.org/280534@main> Reviewed commits have been landed. Closing PR #30103 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.