Bug 212764
| Summary: | [EWS] Should be able to specify a subset of ports when posting patches to fix port builds | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | aakash_jain, achristensen, ap, darin |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=212605 | ||
David Kilzer (:ddkilzer)
Should be able to specify a subset of ports when posting patches to fix port builds.
It's a waste of resources to post patches just to find out if you've fixed all the compiler errors for a subset of ports.
It would be nice if there was a way to specify which port(s) a patch should be run on so EWS doesn't spend time building and running tests on patches meant to test build fixes.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
I'm skeptical about this. This would make it really difficult to tell if EWS was green. And I don't know how much EWS should trust engineer's opinion that they didn't break anything unexpectedly.
David Kilzer (:ddkilzer)
(In reply to Alexey Proskuryakov from comment #1)
> I'm skeptical about this. This would make it really difficult to tell if EWS
> was green. And I don't know how much EWS should trust engineer's opinion
> that they didn't break anything unexpectedly.
We could use a different color for bubbles with skipped platforms.
This would not be used for the "final" patch for review; only for intermediate patches where an engineer is trying to make a patch compile for a port that they don't have access to build.
Obviously this requires some trust, but marking skipped platforms with a different color would make this pretty obvious. Maybe commit-queue could refuse to commit a patch with skipped platforms, too.
Of course, maybe developers would be too lazy to use this anyway, so implementing it wouldn't be useful. :)