Bug 212398

Summary:

Web Inspector: match the undocked tab bar style when docked bottom/side

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, pangle, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

204627

Bug Blocks:

Attachments:

Description	Flags
Patch	none
[Image] after Patch is applied (docked bottom - light)	none
[Image] after Patch is applied (docked side - light)	none
[Image] after Patch is applied (docked bottom - dark)	none
[Image] after Patch is applied (docked side - dark)	none
Patch	none
[Image] after Patch is applied (docked bottom - light)	none
[Image] after Patch is applied (docked side - light)	none
[Image] after Patch is applied (docked bottom - dark)	none
[Image] after Patch is applied (docked side - dark)	none

Devin Rousso

Reported 2020-05-26 19:29:35 PDT

see screenshots attached to <https://webkit.org/b/204627>

Attachments
Patch (30.68 KB, patch) 2020-05-26 19:52 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
[Image] after Patch is applied (docked bottom - light) (3.92 MB, image/png) 2020-05-26 19:53 PDT, Devin Rousso	no flags	Details
[Image] after Patch is applied (docked side - light) (3.40 MB, image/png) 2020-05-26 19:53 PDT, Devin Rousso	no flags	Details
[Image] after Patch is applied (docked bottom - dark) (3.97 MB, image/png) 2020-05-26 20:00 PDT, Devin Rousso	no flags	Details
[Image] after Patch is applied (docked side - dark) (3.50 MB, image/png) 2020-05-26 20:01 PDT, Devin Rousso	no flags	Details
Patch (47.30 KB, patch) 2021-08-09 13:12 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
[Image] after Patch is applied (docked bottom - light) (3.40 MB, image/png) 2021-08-09 13:12 PDT, Devin Rousso	no flags	Details
[Image] after Patch is applied (docked side - light) (3.02 MB, image/png) 2021-08-09 13:13 PDT, Devin Rousso	no flags	Details
[Image] after Patch is applied (docked bottom - dark) (3.43 MB, image/png) 2021-08-09 13:13 PDT, Devin Rousso	no flags	Details
[Image] after Patch is applied (docked side - dark) (2.48 MB, image/png) 2021-08-09 13:13 PDT, Devin Rousso	no flags	Details
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2020-05-26 19:52:21 PDT

Created attachment 400297 [details] Patch

Devin Rousso

Comment 2 2020-05-26 19:53:21 PDT

Created attachment 400298 [details] [Image] after Patch is applied (docked bottom - light)

Devin Rousso

Comment 3 2020-05-26 19:53:50 PDT

Created attachment 400299 [details] [Image] after Patch is applied (docked side - light)

Devin Rousso

Comment 4 2020-05-26 20:00:49 PDT

Created attachment 400300 [details] [Image] after Patch is applied (docked bottom - dark)

Devin Rousso

Comment 5 2020-05-26 20:01:04 PDT

Created attachment 400301 [details] [Image] after Patch is applied (docked side - dark)

Maciej Stachowiak

Comment 6 2020-05-26 20:59:11 PDT

Comment on attachment 400297 [details] Patch I don’t think this is an improvement. While it avoids the problem of all white, it reintroduces the problem when tabs stack in the side docked configuration (and makes bottom-docked look weird). I don’t want to get into a review fight here but I don’t think this is shippable.

Devin Rousso

Comment 7 2021-08-09 13:12:17 PDT

Created attachment 435202 [details] Patch

Devin Rousso

Comment 8 2021-08-09 13:12:39 PDT

Created attachment 435203 [details] [Image] after Patch is applied (docked bottom - light)

Devin Rousso

Comment 9 2021-08-09 13:13:00 PDT

Created attachment 435204 [details] [Image] after Patch is applied (docked side - light)

Devin Rousso

Comment 10 2021-08-09 13:13:18 PDT

Created attachment 435205 [details] [Image] after Patch is applied (docked bottom - dark)

Devin Rousso

Comment 11 2021-08-09 13:13:36 PDT

Created attachment 435206 [details] [Image] after Patch is applied (docked side - dark)

Joseph Pecoraro

Comment 12 2021-08-09 13:23:20 PDT

Looks nice!

Patrick Angle

Comment 13 2021-08-09 15:59:01 PDT

Comment on attachment 435202 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435202&action=review Looks great! Glad to see a single design for this between modes instead of two different designs with different spacing. > Source/WebCore/inspector/InspectorFrontendHost.cpp:396 > +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000 Is there a specific reason we don't use the platform macros for these version numbers (which I think is what the style bot is grumpy about) e.g. `__MAC_12_0`, `__MAC_11_0`, `__MAC_10_15`, and `__MAC_10_14`? Similar use already in `/source/thirdparty/angle/src/libangle/renderer/metal/mtl_utils.mm`. I do see many other places we have hardcoded these values throughout WebKit though...

Blaze Burg

Comment 14 2021-08-10 08:31:06 PDT

(In reply to Patrick Angle from comment #13) > Comment on attachment 435202 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=435202&action=review > > Looks great! Glad to see a single design for this between modes instead of > two different designs with different spacing. > > > Source/WebCore/inspector/InspectorFrontendHost.cpp:396 > > +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000 > > Is there a specific reason we don't use the platform macros for these > version numbers (which I think is what the style bot is grumpy about) e.g. > `__MAC_12_0`, `__MAC_11_0`, `__MAC_10_15`, and `__MAC_10_14`? Similar use > already in > `/source/thirdparty/angle/src/libangle/renderer/metal/mtl_utils.mm`. I do > see many other places we have hardcoded these values throughout WebKit > though... Those are macros in 3rd party code. I believe WebKit is still using hardcoded version numbers.. but I could be wrong?

EWS

Comment 15 2021-08-17 23:50:23 PDT

Committed r281182 (240627@main): <https://commits.webkit.org/240627@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435202 [details].

Radar WebKit Bug Importer

Comment 16 2021-08-17 23:51:32 PDT

<rdar://problem/82064001>

Note You need to log in before you can comment on or make changes to this bug.