Bug 207985

Summary: [WebAuthn] Replace DeviceIdentity.framework
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebKit Misc.Assignee: Jiewen Tan <jiewen_tan>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, commit-queue, dbates, e.barg0089, ews-watchlist, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 181943    
Attachments:
Description Flags
Patch
bfulgham: review+
Patch for landing none

Jiewen Tan
Reported 2020-02-19 19:42:05 PST
Adopt Apple attestation.
Attachments
Patch (54.46 KB, patch)
2020-02-19 21:01 PST, Jiewen Tan 		bfulgham: review+
DetailsFormatted DiffDiff
Patch for landing (54.38 KB, patch)
2020-02-20 13:00 PST, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2020-02-19 19:42:59 PST
<rdar://problem/59369223>
Jiewen Tan
Comment 2 2020-02-19 21:01:51 PST
Created attachment 391254 [details] Patch
Jiewen Tan
Comment 3 2020-02-19 23:24:39 PST
Comment on attachment 391254 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391254&action=review > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:312 > + WTFLogAlways("Couldn't attest: %@", error); Should actually be LOG_ERROR.
Brent Fulgham
Comment 4 2020-02-20 10:18:07 PST
Comment on attachment 391254 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391254&action=review r=me > Source/WebKit/ChangeLog:10 > + Invocations of the new framework is hidden in WKA. Please refer to the radar for detailed information. "The new experimental authentication logic is handled by WebKtAdditions. Please refer to the radar for detailed information." > Source/WebKit/ChangeLog:13 > + 1) changes the way how user consent is obtained such that biometrics will not be prompted twice. changes how user consent is obtained to avoid multiple prompts for biometric input. > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:174 > "allow " + creationOptions.rp.id + " to create a public key credential for " + creationOptions.user.name, Should this be "makeString("allow "_s, creationOptions.rp.id, " to create a public key credential for"_s, creationOptions.user.name)
Jiewen Tan
Comment 5 2020-02-20 12:23:13 PST
Comment on attachment 391254 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391254&action=review Thanks Brent for r+ the patch. >> Source/WebKit/ChangeLog:10 >> + Invocations of the new framework is hidden in WKA. Please refer to the radar for detailed information. > > "The new experimental authentication logic is handled by WebKtAdditions. Please refer to the radar for detailed information." Fixed. >> Source/WebKit/ChangeLog:13 >> + 1) changes the way how user consent is obtained such that biometrics will not be prompted twice. > > changes how user consent is obtained to avoid multiple prompts for biometric input. Fixed. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:174 >> "allow " + creationOptions.rp.id + " to create a public key credential for " + creationOptions.user.name, > > Should this be "makeString("allow "_s, creationOptions.rp.id, " to create a public key credential for"_s, creationOptions.user.name) Yes. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:312 >> + WTFLogAlways("Couldn't attest: %@", error); > > Should actually be LOG_ERROR. Fixed. > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.h:38 > +namespace WebCore { Not needed.
Jiewen Tan
Comment 6 2020-02-20 13:00:06 PST
Created attachment 391321 [details] Patch for landing
WebKit Commit Bot
Comment 7 2020-02-20 14:05:22 PST
The commit-queue encountered the following flaky tests while processing attachment 391321 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2020-02-20 14:06:04 PST
Comment on attachment 391321 [details] Patch for landing Clearing flags on attachment: 391321 Committed r257085: <https://trac.webkit.org/changeset/257085>
Note You need to log in before you can comment on or make changes to this bug.