Bug 206813

Summary: [LFC][IFC] Display::LineBox has one type of geometry only.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: NEW    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 215087    
Attachments:
Description Flags
Patch none

alan
Reported 2020-01-26 17:41:52 PST
LineBox can either be logical or physical.
Attachments
Patch (38.58 KB, patch)
2020-01-26 17:46 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2020-01-26 17:46:45 PST
Created attachment 388819 [details] Patch
Antti Koivisto
Comment 2 2020-01-27 07:20:13 PST
Comment on attachment 388819 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388819&action=review > Source/WebCore/ChangeLog:8 > + It can either represent a logical line box (during layout) or a physical one (during paint/hittest). This doesn't feel right. Shouldn't we have separate classes for these cases?
alan
Comment 3 2020-01-27 09:01:16 PST
(In reply to Antti Koivisto from comment #2) > Comment on attachment 388819 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388819&action=review > > > Source/WebCore/ChangeLog:8 > > + It can either represent a logical line box (during layout) or a physical one (during paint/hittest). > > This doesn't feel right. Shouldn't we have separate classes for these cases? Yes, that would be cleaner and more inline with what we do with runs. It also implies that we should do something similar with Display::InlineRect/Rect too.
Note You need to log in before you can comment on or make changes to this bug.