Bug 206475

Summary: Make isValidUserAgentHeaderValue GLib only
Product: WebKit Reporter: Rob Buis <rbuis>
Component: New BugsAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Rob Buis
Reported 2020-01-18 11:30:09 PST
The function isValidUserAgentHeaderValue is only used by code that requires GLib, so move it behind USE(GLIB).
Attachments
Patch (3.95 KB, patch)
2020-01-18 11:32 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-01-18 11:32:43 PST
Created attachment 388158 [details] Patch
WebKit Commit Bot
Comment 2 2020-01-20 02:58:41 PST
The commit-queue encountered the following flaky tests while processing attachment 388158 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 3 2020-01-20 02:59:13 PST
Comment on attachment 388158 [details] Patch Clearing flags on attachment: 388158 Committed r254818: <https://trac.webkit.org/changeset/254818>
WebKit Commit Bot
Comment 4 2020-01-20 02:59:15 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2020-01-20 03:00:30 PST
<rdar://problem/58734822>
Note You need to log in before you can comment on or make changes to this bug.