Bug 206311

Summary: Web Inspector: show the device settings menu when Web Inspector's debug mode is enabled
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
bburg: review+
Patch none

Devin Rousso
Reported 2020-01-15 13:38:57 PST
.
Attachments
Patch (2.41 KB, patch)
2020-01-15 13:41 PST, Devin Rousso 		bburg: review+
DetailsFormatted DiffDiff
Patch (2.41 KB, patch)
2020-01-16 16:39 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-01-15 13:41:40 PST
Created attachment 387838 [details] Patch
Blaze Burg
Comment 2 2020-01-16 16:37:30 PST
Comment on attachment 387838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387838&action=review rs=me, except speling. > Source/WebInspectorUI/ChangeLog:11 > + toolbar icon, but it will not reapper when Web Inspector is next opened (to allow for taking Nit: reappear
Devin Rousso
Comment 3 2020-01-16 16:39:02 PST
Created attachment 387983 [details] Patch
WebKit Commit Bot
Comment 4 2020-01-16 17:14:13 PST
The commit-queue encountered the following flaky tests while processing attachment 387983 [details]: imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors-large.html bug 201849 The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2020-01-16 17:14:44 PST
Comment on attachment 387983 [details] Patch Clearing flags on attachment: 387983 Committed r254727: <https://trac.webkit.org/changeset/254727>
WebKit Commit Bot
Comment 6 2020-01-16 17:14:45 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-01-16 17:15:12 PST
<rdar://problem/58665014>
Note You need to log in before you can comment on or make changes to this bug.