Bug 205908

Summary: canvas-createImageBitmap-video-resize.html fails after importing /media/ on GTK platform
Product: WebKit Reporter: cathiechen <cathiechen>
Component: MediaAssignee: cathiechen <cathiechen>
Status: RESOLVED FIXED    
Severity: Normal CC: clord, commit-queue, eric.carlson, ews-watchlist, glenn, jbedard, jer.noble, philipj, rego, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 205678    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

cathiechen
Reported 2020-01-08 00:10:19 PST
canvas-createImageBitmap-video-resize.html has a video element with /media/video.ogv. It generated a timeout error if /media/video.ogv is not imported. After importing /media/video.ogv, WebKitGTK support .ogv, so it can pass the test. For the platforms not supporting .ogv, it will also get a timeout error.
Attachments
Patch (1.35 KB, patch)
2020-01-08 00:20 PST, cathiechen 		no flags
DetailsFormatted DiffDiff
Patch (15.99 KB, patch)
2020-01-09 06:43 PST, cathiechen 		no flags
DetailsFormatted DiffDiff
Patch (19.28 KB, patch)
2020-01-10 03:11 PST, cathiechen 		no flags
DetailsFormatted DiffDiff
Patch (19.29 KB, patch)
2020-01-10 06:38 PST, cathiechen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
cathiechen
Comment 1 2020-01-08 00:20:14 PST
Created attachment 387084 [details] Patch
Manuel Rego Casasnovas
Comment 2 2020-01-08 00:50:49 PST
Maybe doing something like other tests do could make this pass in Mac too: video.src = '../resources/video.' + (video.canPlayType('video/ogg') ? 'ogv' : 'mp4'; Dunno really. I don't know what's the best approach here, if we should just skip this test for Mac or try something like the previous line (even when video.mp4 doesn't exist on that folder I guess we could use test.mp4, dunno if using video.ogv instead of test.ogv is relevant for the test).
cathiechen
Comment 3 2020-01-08 06:32:11 PST
Comment on attachment 387084 [details] Patch Thanks rego! I'm agree with you. FYI, we are trying to make this test compatible. https://github.com/web-platform-tests/wpt/pull/21084
cathiechen
Comment 4 2020-01-09 06:43:02 PST
Created attachment 387219 [details] Patch
cathiechen
Comment 5 2020-01-10 03:11:29 PST
Created attachment 387323 [details] Patch
cathiechen
Comment 6 2020-01-10 04:40:45 PST
Comment on attachment 387323 [details] Patch Hi, This patch is ready to review. PTAL, thanks:)
Manuel Rego Casasnovas
Comment 7 2020-01-10 04:49:02 PST
Comment on attachment 387323 [details] Patch r=me Thanks for taking care of fixing this in WPT. Please wait for EWSs before landing.
cathiechen
Comment 8 2020-01-10 06:38:59 PST
Created attachment 387335 [details] Patch
cathiechen
Comment 9 2020-01-11 08:39:54 PST
accessibility/mac/select-text/select-text-1.html fails on mac-debug-wk1. It is not related to this patch.
WebKit Commit Bot
Comment 10 2020-01-11 09:31:17 PST
The commit-queue encountered the following flaky tests while processing attachment 387335 [details]: inspector/runtime/executionContextCreated-onEnable.html bug 206130 (author: yurys@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 11 2020-01-11 09:32:07 PST
Comment on attachment 387335 [details] Patch Clearing flags on attachment: 387335 Committed r254399: <https://trac.webkit.org/changeset/254399>
WebKit Commit Bot
Comment 12 2020-01-11 09:32:08 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2020-01-11 09:33:15 PST
<rdar://problem/58504598>
Note You need to log in before you can comment on or make changes to this bug.